Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8150303: Rewrite test/tools/javac/Paths/Diagnostics.sh #1959

Open
wants to merge 2 commits into
base: master
from

Conversation

@lgxbslgx
Copy link
Member

@lgxbslgx lgxbslgx commented Jan 6, 2021

Hi all,

This patch rewrites Diagnostics.sh to java code by using ToolBox API.
And I have a question: What does the elts mean in the following comments? Is it elements?
I think that a meaningful name should be used.

// Warn for missing elts in user-specified paths
// No warning for missing elts in "system" paths

Thank you for taking the time to review.

Best Regards.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8150303: Rewrite test/tools/javac/Paths/Diagnostics.sh

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1959/head:pull/1959
$ git checkout pull/1959

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 6, 2021

👋 Welcome back lgxbslgx! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 6, 2021

@lgxbslgx The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler label Jan 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 6, 2021

Webrevs

@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Jan 6, 2021

This patch rewrites Diagnostics.sh to java code by using ToolBox API.
And I have a question: What does the elts mean in the following comments? Is it elements?
I think that a meaningful name should be used.

Brave person. There's a reason no one has converted this test so far.

To answer your specific question: yes, elts should be read as an abbreviation for elements and yes, it would be good to clarify it.

@lgxbslgx
Copy link
Member Author

@lgxbslgx lgxbslgx commented Jan 7, 2021

@jonathan-gibbons Thank you for your answer. I modify elts to elements.

And I revise the test code about line separator because the test failed at windows in the pre-submit tests.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 4, 2021

@lgxbslgx This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 4, 2021

@lgxbslgx This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it!

@bridgekeeper bridgekeeper bot closed this Mar 4, 2021
@lgxbslgx
Copy link
Member Author

@lgxbslgx lgxbslgx commented Apr 22, 2021

/open

@openjdk openjdk bot reopened this Apr 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@lgxbslgx @HostUserDetails{id=13688759, username='lgxbslgx', fullName='null'} this pull request is now open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants