Skip to content

8333823: Update --release 23 symbol information for JDK 23 build 26 #19603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Jun 7, 2024

Usual symbol file update for a new JDK build.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8333823: Update --release 23 symbol information for JDK 23 build 26 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19603/head:pull/19603
$ git checkout pull/19603

Update a local copy of the PR:
$ git checkout pull/19603
$ git pull https://git.openjdk.org/jdk.git pull/19603/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19603

View PR using the GUI difftool:
$ git pr show -t 19603

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19603.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2024

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 7, 2024

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333823: Update --release 23 symbol information for JDK 23 build 26

Reviewed-by: iris, jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 18e7d7b: 8333716: Shenandoah: Check for disarmed method before taking the nmethod lock
  • c37d02a: 8312412: Uninitialized klassVtable::_verify_count field
  • 17bd483: 8333680: com/sun/tools/attach/BasicTests.java fails with "SocketException: Permission denied: connect"
  • 512b2b4: 8330420: Inverted use of DisplayVMOutputToStderr in ostream_exit
  • 8e72d7c: 8320448: Accelerate IndexOf using AVX2
  • 25ad862: 8332161: Test restoring echo in the Console implementation (java.base)
  • ee82346: 8325984: 4 jcstress tests are failing in Tier6 4 times each
  • d744059: 8333774: Avoid eagerly loading various EmptySpliterator classes
  • d130d2f: 8333477: Delete extra empty spaces in Makefiles
  • 486dee2: 8333653: Remove MallocHeader::get_stack
  • ... and 11 more: https://git.openjdk.org/jdk/compare/2a37764e7428d579a3080e62681f1c9c9f816c1e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8333823: Update --release 23 symbol information for JDK 23 build 26 8333823: Update --release 23 symbol information for JDK 23 build 26 Jun 7, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 7, 2024
@openjdk
Copy link

openjdk bot commented Jun 7, 2024

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Jun 7, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2024

Webrevs

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, change applies to JDK 24 so PR correctly against master branch.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 7, 2024
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@jddarcy
Copy link
Member Author

jddarcy commented Jun 7, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 7, 2024

Going to push as commit cf677c9.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 18e7d7b: 8333716: Shenandoah: Check for disarmed method before taking the nmethod lock
  • c37d02a: 8312412: Uninitialized klassVtable::_verify_count field
  • 17bd483: 8333680: com/sun/tools/attach/BasicTests.java fails with "SocketException: Permission denied: connect"
  • 512b2b4: 8330420: Inverted use of DisplayVMOutputToStderr in ostream_exit
  • 8e72d7c: 8320448: Accelerate IndexOf using AVX2
  • 25ad862: 8332161: Test restoring echo in the Console implementation (java.base)
  • ee82346: 8325984: 4 jcstress tests are failing in Tier6 4 times each
  • d744059: 8333774: Avoid eagerly loading various EmptySpliterator classes
  • d130d2f: 8333477: Delete extra empty spaces in Makefiles
  • 486dee2: 8333653: Remove MallocHeader::get_stack
  • ... and 11 more: https://git.openjdk.org/jdk/compare/2a37764e7428d579a3080e62681f1c9c9f816c1e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 7, 2024
@openjdk openjdk bot closed this Jun 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 7, 2024
@openjdk
Copy link

openjdk bot commented Jun 7, 2024

@jddarcy Pushed as commit cf677c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8333823 branch October 26, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants