New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8259319: Illegal package access when SunPKCS11 requires SunJCE's classes #1961
Conversation
|
Webrevs
|
Obscure bug, thanks for report and the fix. I will take a look. |
src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Util.java
Outdated
Show resolved
Hide resolved
test/jdk/sun/security/pkcs11/KeyAgreement/IllegalPackageAccess.java
Outdated
Show resolved
Hide resolved
src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Util.java
Outdated
Show resolved
Hide resolved
…lassInPackage' RuntimePermission only.
New proposal limiting the privileges in P11Util::getProvider method and adding a new line character at the end of the IllegalPackageAccess test file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
@martinuy This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 116 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
@martinuy Since your change was applied there have been 147 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 4be2173. |
As described in JDK-8259319 [1], this fix proposal is to set proper access permissions so the SunPKCS11 provider can create instances of SunJCE classes when a Security Manager is installed and the fallback scheme is used.
No regressions found in jdk/sun/security/pkcs11 tests category.
--
[1] - https://bugs.openjdk.java.net/browse/JDK-8259319
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1961/head:pull/1961
$ git checkout pull/1961