Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259319: Illegal package access when SunPKCS11 requires SunJCE's classes #1961

Closed
wants to merge 3 commits into from

Conversation

@martinuy
Copy link
Contributor

@martinuy martinuy commented Jan 6, 2021

As described in JDK-8259319 [1], this fix proposal is to set proper access permissions so the SunPKCS11 provider can create instances of SunJCE classes when a Security Manager is installed and the fallback scheme is used.

No regressions found in jdk/sun/security/pkcs11 tests category.

--
[1] - https://bugs.openjdk.java.net/browse/JDK-8259319


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259319: Illegal package access when SunPKCS11 requires SunJCE's classes

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1961/head:pull/1961
$ git checkout pull/1961

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 6, 2021

👋 Welcome back mbalao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 6, 2021

@martinuy The following labels will be automatically applied to this pull request:

  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 6, 2021

Webrevs

@valeriepeng
Copy link

@valeriepeng valeriepeng commented Jan 7, 2021

Obscure bug, thanks for report and the fix. I will take a look.

@martinuy
Copy link
Contributor Author

@martinuy martinuy commented Jan 8, 2021

New proposal limiting the privileges in P11Util::getProvider method and adding a new line character at the end of the IllegalPackageAccess test file.

Copy link

@valeriepeng valeriepeng left a comment

Changes look good.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@martinuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259319: Illegal package access when SunPKCS11 requires SunJCE's classes

Reviewed-by: valeriep, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 116 new commits pushed to the master branch:

  • 8dfc77b: 8259586: ProblemList dll_address_to_function_and_library_name
  • d9f2134: 8258655: remove <-- NewPage --> comment from generated pages
  • c956e7a: 8258659: Eliminate whitespace comments from generated pages
  • 3861960: 8258426: Split up autoconf/version-numbers and move it to conf dir
  • dab1787: 8259559: COMPARE_BUILD can't compare patch files
  • cf3e4bf: 8258838: Remove JVM option UseStackBanging
  • 33fbc10: 8259025: Record compact constructor using Objects.requireNonNull
  • 23801da: 8259482: jni_Set/GetField_probe are the same as their _nh versions
  • 01b2804: 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears to not be fully fixed
  • 1bd015f: 8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk
  • ... and 106 more: https://git.openjdk.java.net/jdk/compare/7f04d23be4273f32f40672e9f9f9c1c5d4ac02cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 11, 2021
@martinuy
Copy link
Contributor Author

@martinuy martinuy commented Jan 12, 2021

/integrate

@openjdk openjdk bot closed this Jan 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@martinuy Since your change was applied there have been 147 commits pushed to the master branch:

  • e4df209: 7018932: Drawing very large coordinates with a dashed Stroke can cause Java to hang
  • 5f7ccce: 8226810: Failed to launch JVM because of NullPointerException occured on System.props
  • d6a2105: 8259343: [macOS] Update JNI error handling in Cocoa code.
  • c338f11: 8259349: -XX:AvgMonitorsPerThreadEstimate=1 does not work right
  • ccac7aa: 8258932: AArch64: Enhance floating-point Min/MaxReductionV with fminp/fmaxp
  • 4c75d14: 8259374: Make ThreadInVMfromNative have ResetNoHandleMark
  • 563b268: 8257709: C1: Double assignment in InstructionPrinter::print_stack
  • 400dc76: 8252015: [macos11] java.awt.TrayIcon requires updates for template images
  • ac2dee5: 8259539: JDK-8255711 broke trap messages
  • 4697cfa: 8259576: Misplaced curly brace in Matcher::find_shared_post_visit
  • ... and 137 more: https://git.openjdk.java.net/jdk/compare/7f04d23be4273f32f40672e9f9f9c1c5d4ac02cf...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4be2173.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@martinuy martinuy deleted the martinuy:JDK-8259319 branch May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants