8331675: gtest CollectorPolicy.young_min_ergo_vm fails after 8272364

[albertnetymk]

Remove a gtest test case around NewSize.

The gtest young_min_ergo essentially checks NewSize 20M set ergonomically will be preserved and MinNewSize will be <= 20M. However, the GCArguments::initialize_heap_sizes can overwrite the 20M value, in the process of respecting InitialHeapSize and NewRatio.

A more correct assert would be ASSERT_LE(MinNewSize, NewSize); in CheckYoungMin so that the up-to-date NewSize is picked up. The MinNewSize <= NewSize invariant is already checked in GenArguments::assert_size_info, so this gtest offers little benefit.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8331675: gtest CollectorPolicy.young_min_ergo_vm fails after 8272364

Issue

• JDK-8331675: gtest CollectorPolicy.young_min_ergo_vm fails after 8272364 (Bug - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Zhengyu Gu (@zhengyu123 - Reviewer)
• Guoxiong Li (@lgxbslgx - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19621/head:pull/19621
$ git checkout pull/19621

Update a local copy of the PR:
$ git checkout pull/19621
$ git pull https://git.openjdk.org/jdk.git pull/19621/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19621

View PR using the GUI difftool:
$ git pr show -t 19621

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19621.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331675: gtest CollectorPolicy.young_min_ergo_vm fails after 8272364

Reviewed-by: tschatzl, zgu, gli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 3a01b47: 8330205: Initial troff manpage generation for JDK 24
• 9691153: 8329141: Obsolete RTM flags and code
• 13642cb: 8333828: Use value javadoc tag in java.lang.{Float, Double}
• b254762: 8333829: ProblemList sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java due to JDK-8333317
• b68609f: 8333779: Parallel: Remove Summary phase related debug print during Full GC
• 6ea28fb: 8333641: Serial: Remove Generation::supports_tlab_allocation
• ce5727d: 8333652: RISC-V: compiler/vectorapi/VectorGatherMaskFoldingTest.java fails when using RVV
• e0afe0b: 8326085: Remove unnecessary UpcallContext constructor
• 2a242db: 8325821: [REDO] use "dmb.ishst+dmb.ishld" for release barrier
• e7dc76b: 8333849: (dc) DatagramChannel send/receive fails with UOE if buffer backed by memory segment allocated from shared arena
• ... and 4 more: https://git.openjdk.org/jdk/compare/83b34410e326c47f357a37c3a337b7dedb8cbbda...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (21c5f636)

[zhengyu123]

LGTM

[lgxbslgx]

Looks good.

[albertnetymk]

Thanks for review.

/integrate

[openjdk]

Going to push as commit badf1cb.
Since your change was applied there have been 17 commits pushed to the master branch:

• 4d6064a: 8333649: Allow different NativeCall encodings
• fe9c63c: 8333931: Problemlist serviceability/jvmti/vthread/CarrierThreadEventNotification
• 41c88bc: 8333756: java/lang/instrument/NativeMethodPrefixApp.java failed due to missing intrinsic
• 3a01b47: 8330205: Initial troff manpage generation for JDK 24
• 9691153: 8329141: Obsolete RTM flags and code
• 13642cb: 8333828: Use value javadoc tag in java.lang.{Float, Double}
• b254762: 8333829: ProblemList sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java due to JDK-8333317
• b68609f: 8333779: Parallel: Remove Summary phase related debug print during Full GC
• 6ea28fb: 8333641: Serial: Remove Generation::supports_tlab_allocation
• ce5727d: 8333652: RISC-V: compiler/vectorapi/VectorGatherMaskFoldingTest.java fails when using RVV
• ... and 7 more: https://git.openjdk.org/jdk/compare/83b34410e326c47f357a37c3a337b7dedb8cbbda...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit badf1cb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.