-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8333722: Fix CompilerDirectives for non-compiler JVM variants #19622
8333722: Fix CompilerDirectives for non-compiler JVM variants #19622
Conversation
👋 Welcome back simonis! A progress list of the required criteria for merging this PR into |
@simonis This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
Thanks @TobiHartmann! |
/integrate |
Going to push as commit fdbc2b2. |
Hi all,
This pull request contains a backport of commit 5f9d3e3 from the openjdk/jdk repository.
The commit being backported was authored by Volker Simonis on 10 Jun 2024 and was reviewed by Vladimir Kozlov.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19622/head:pull/19622
$ git checkout pull/19622
Update a local copy of the PR:
$ git checkout pull/19622
$ git pull https://git.openjdk.org/jdk.git pull/19622/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19622
View PR using the GUI difftool:
$ git pr show -t 19622
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19622.diff
Webrev
Link to Webrev Comment