Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333722: Fix CompilerDirectives for non-compiler JVM variants #19622

Closed

Conversation

simonis
Copy link
Member

@simonis simonis commented Jun 10, 2024

Hi all,

This pull request contains a backport of commit 5f9d3e3 from the openjdk/jdk repository.

The commit being backported was authored by Volker Simonis on 10 Jun 2024 and was reviewed by Vladimir Kozlov.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8333722: Fix CompilerDirectives for non-compiler JVM variants (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19622/head:pull/19622
$ git checkout pull/19622

Update a local copy of the PR:
$ git checkout pull/19622
$ git pull https://git.openjdk.org/jdk.git pull/19622/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19622

View PR using the GUI difftool:
$ git pr show -t 19622

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19622.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2024

👋 Welcome back simonis! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 10, 2024

@simonis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333722: Fix CompilerDirectives for non-compiler JVM variants

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk23 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 5f9d3e3af8342592242cb304b2c219508d56ed3a 8333722: Fix CompilerDirectives for non-compiler JVM variants Jun 10, 2024
@openjdk
Copy link

openjdk bot commented Jun 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 10, 2024
@openjdk
Copy link

openjdk bot commented Jun 10, 2024

@simonis The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 10, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2024

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 10, 2024
@simonis
Copy link
Member Author

simonis commented Jun 10, 2024

Thanks @TobiHartmann!

@simonis
Copy link
Member Author

simonis commented Jun 10, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 10, 2024

Going to push as commit fdbc2b2.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 10, 2024
@openjdk openjdk bot closed this Jun 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 10, 2024
@openjdk
Copy link

openjdk bot commented Jun 10, 2024

@simonis Pushed as commit fdbc2b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants