Skip to content

8333940: Ensure javax/swing/TestUngrab.java run on all platforms #19644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jun 11, 2024

TestUngrab.java was added for JDK-8267374 macos fix but the test can be run for all platforms as the behaviour is common for all
CI run job link in JBS..


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8333940: Ensure javax/swing/TestUngrab.java run on all platforms (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19644/head:pull/19644
$ git checkout pull/19644

Update a local copy of the PR:
$ git checkout pull/19644
$ git pull https://git.openjdk.org/jdk.git pull/19644/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19644

View PR using the GUI difftool:
$ git pr show -t 19644

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19644.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 11, 2024

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 11, 2024

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333940: Ensure javax/swing/TestUngrab.java run on all platforms

Reviewed-by: tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • a7205cc: 8333926: Shenandoah: Lower default immediate garbage threshold
  • 56e8e60: 8330534: Update nsk/jdwp tests to use driver instead of othervm
  • bbd3b1d: 8334036: Update JCov for class file version 68
  • 7ed8a5c: 8333841: Add more logging into setfldw001 tests
  • b77bd5f: 8333742: ProcessImpl and ProcessHandleImpl may mishandle processes that exit with code 259
  • aaaa86b: 8333360: PrintNullString.java doesn't use float arguments
  • ef101f1: 8332920: C2: Partial Peeling is wrongly applied for CmpU with negative limit
  • 2843745: 8333972: Parallel: Remove unused methods in PSOldGen
  • 93f3918: 8333954: Parallel: Remove unused arguments of type ParCompactionManager*
  • 788b876: 8333917: G1: Refactor G1CollectedHeap::register_old_region_with_region_attr
  • ... and 5 more: https://git.openjdk.org/jdk/compare/3a01b47ac97714608356ce3faf797c37dc63e9af...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 11, 2024
@openjdk
Copy link

openjdk bot commented Jun 11, 2024

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jun 11, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 11, 2024

Webrevs

@@ -27,7 +27,6 @@
* @test
* @bug 8267374
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the current bug id be updated here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we only put the product ids in the tag and this is test-only fix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 12, 2024
@kumarabhi006
Copy link
Contributor

TestUngrab.java was added for JDK-8267374 macos fix.

I think that this test was added for JDK-8325435 that you recently integrated. Please verify and update the description.

@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 12, 2024

Going to push as commit 1c80ddb.
Since your change was applied there have been 15 commits pushed to the master branch:

  • a7205cc: 8333926: Shenandoah: Lower default immediate garbage threshold
  • 56e8e60: 8330534: Update nsk/jdwp tests to use driver instead of othervm
  • bbd3b1d: 8334036: Update JCov for class file version 68
  • 7ed8a5c: 8333841: Add more logging into setfldw001 tests
  • b77bd5f: 8333742: ProcessImpl and ProcessHandleImpl may mishandle processes that exit with code 259
  • aaaa86b: 8333360: PrintNullString.java doesn't use float arguments
  • ef101f1: 8332920: C2: Partial Peeling is wrongly applied for CmpU with negative limit
  • 2843745: 8333972: Parallel: Remove unused methods in PSOldGen
  • 93f3918: 8333954: Parallel: Remove unused arguments of type ParCompactionManager*
  • 788b876: 8333917: G1: Refactor G1CollectedHeap::register_old_region_with_region_attr
  • ... and 5 more: https://git.openjdk.org/jdk/compare/3a01b47ac97714608356ce3faf797c37dc63e9af...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 12, 2024
@openjdk openjdk bot closed this Jun 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 12, 2024
@openjdk
Copy link

openjdk bot commented Jun 12, 2024

@prsadhuk Pushed as commit 1c80ddb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the test-fix branch June 12, 2024 05:34
@kumarabhi006
Copy link
Contributor

There are few unused imports in the test.

import java.awt.event.ActionEvent;
import java.awt.event.KeyEvent;
import java.awt.event.MouseEvent;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants