-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8333940: Ensure javax/swing/TestUngrab.java run on all platforms #19644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@@ -27,7 +27,6 @@ | |||
* @test | |||
* @bug 8267374 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the current bug id be updated here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we only put the product ids in the tag and this is test-only fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
I think that this test was added for JDK-8325435 that you recently integrated. Please verify and update the description. |
/integrate |
Going to push as commit 1c80ddb.
Your commit was automatically rebased without conflicts. |
There are few unused imports in the test. import java.awt.event.ActionEvent; |
TestUngrab.java was added for JDK-8267374 macos fix but the test can be run for all platforms as the behaviour is common for all
CI run job link in JBS..
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19644/head:pull/19644
$ git checkout pull/19644
Update a local copy of the PR:
$ git checkout pull/19644
$ git pull https://git.openjdk.org/jdk.git pull/19644/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19644
View PR using the GUI difftool:
$ git pr show -t 19644
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19644.diff
Webrev
Link to Webrev Comment