8259339: AllocateUninitializedArray C2 intrinsic fails with void.class input

[TobiHartmann]

Since JDK-8150465, LibraryCallKit::inline_unsafe_newArray is also used by the _allocateUninitializedArray intrinsic. To handle a void.class input, a runtime (slow) call to the intrinsified method is emitted. We hit a guarantee in generate_method_call_static because a wrong intrinsic id is passed. Also, the call to Unsafe.allocateUninitializedArray0 should be virtual.

I found this when running Valhalla stress testing with -XX:PerMethodTrapLimit=0 but it easily reproduces without (see modified test).

Thanks,
Tobias

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259339: AllocateUninitializedArray C2 intrinsic fails with void.class input

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1965/head:pull/1965
$ git checkout pull/1965

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d3986fd)

[vnkozlov]

Good.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259339: AllocateUninitializedArray C2 intrinsic fails with void.class input

Reviewed-by: kvn, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 81c0624: 8259354: Fix race condition in AbstractEventStream.nextThreadName
• 227f99d: 8233555: [TESTBUG] JRadioButton tests failing on MacoS
• 67c2211: 8259045: Exception message from saproc.dll is garbled on Windows with Japanese locale
• 28e1f4d: 8247957: remove doclint support for HTML 4
• 80544e4: 8250564: Remove terminally deprecated constructor in GSSUtil
• 940b053: 8259232: Bad JNI lookup during printing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Thanks Vladimir!

[chhagedorn]

Looks good!

[TobiHartmann]

/integrate

[TobiHartmann]

Thanks Christian!

[openjdk]

@TobiHartmann Since your change was applied there have been 6 commits pushed to the master branch:

• 81c0624: 8259354: Fix race condition in AbstractEventStream.nextThreadName
• 227f99d: 8233555: [TESTBUG] JRadioButton tests failing on MacoS
• 67c2211: 8259045: Exception message from saproc.dll is garbled on Windows with Japanese locale
• 28e1f4d: 8247957: remove doclint support for HTML 4
• 80544e4: 8250564: Remove terminally deprecated constructor in GSSUtil
• 940b053: 8259232: Bad JNI lookup during printing

Your commit was automatically rebased without conflicts.

Pushed as commit 0e6de4e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.