8327793: Deprecate jstatd for removal

[kevinjwalls]

jstatd is an RMI server application which monitors HotSpot VMs, and provides an interface to the monitoring tool jstat, for use across a remote RMI connection.

RMI is not how modern applications communicate. It is an old transport with long term security concerns, and configuration difficulties with firewalls.

The jstatd tool should be removed. Deprecating and removing jstatd will not affect usage of jstat for monitoring local VMs using the Attach API.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8332633 to be approved

Issues

• JDK-8327793: Deprecate jstatd for removal (Enhancement - P4)
• JDK-8332633: Deprecate jstatd for removal (CSR)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer) ⚠️ Review applies to 3c7e86a1
• Chris Plummer (@plummercj - Reviewer) ⚠️ Review applies to 3c7e86a1

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19658/head:pull/19658
$ git checkout pull/19658

Update a local copy of the PR:
$ git checkout pull/19658
$ git pull https://git.openjdk.org/jdk.git pull/19658/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19658

View PR using the GUI difftool:
$ git pr show -t 19658

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19658.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327793: Deprecate jstatd for removal

Reviewed-by: alanb, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kevinjwalls The following labels will be automatically applied to this pull request:

• core-libs
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full - Incremental (db53d078)
• 05: Full - Incremental (1a240155)
• 04: Full - Incremental (3c7e86a1)
• 03: Full - Incremental (ed386505)
• 02: Full - Incremental (58892d76)
• 01: Full - Incremental (72ac8818)
• 00: Full (60bde969)

[AlanBateman]

The sun.jvmstat.monitor.remote package is not exported so I don't think adding @Deprecated makes sense.

Look at JDK-8245068 when rmid was deprecated and see the warning that it printed. I think it's the warning piece (like you have in Jstatd.main) that you'll need here.

[kevinjwalls]

The sun.jvmstat.monitor.remote package is not exported so I don't think adding @Deprecated makes sense.

Sure, happy to not add annotations in sun.jvmstat.monitor.remote (RemoteHost.java, RemoteVm.java).

[AlanBateman]

Sure, happy to not add annotations in sun.jvmstat.monitor.remote (RemoteHost.java, RemoteVm.java).

Right, you can drop it from all the source files except for module-info.java.

[AlanBateman]

BTW: Are you going to include the update to the man page (jstatd.1) in the PR or is that for another update?

[kevinjwalls]

OK sure - I had thought the src annotations were useful but if not needed I am taking them out.

Yes, I was thinking to do a separate man page CR.

[AlanBateman]

Changes look okay now. Will you update the CSR to align with the PR?

[kevinjwalls]

/INTEGRATE

[kevinjwalls]

/integrate

[openjdk]

Going to push as commit 9f8de22.
Since your change was applied there has been 1 commit pushed to the master branch:

• dbf5a9a: 8334706: [JVMCI] APX registers incorrectly exposed on AMD64

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinjwalls Pushed as commit 9f8de22.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.