Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259317: Remove JVM option BreakAtWarning #1966

Closed
wants to merge 1 commit into from

Conversation

@hseigel
Copy link
Member

@hseigel hseigel commented Jan 6, 2021

Please review this trivial change to remove the old JVM develop BreakAtWarning flag.

The change was tested with Mach5 tiers 1-3 on Linux, Windows, and Mac OS.

Thanks, Harold


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1966/head:pull/1966
$ git checkout pull/1966

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 6, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 6, 2021

@hseigel The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Jan 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 6, 2021

Webrevs

lfoltan
lfoltan approved these changes Jan 6, 2021
Copy link
Member

@lfoltan lfoltan left a comment

LGTM.
Lois

@openjdk
Copy link

@openjdk openjdk bot commented Jan 6, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259317: Remove JVM option BreakAtWarning

Reviewed-by: lfoltan, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 80544e4: 8250564: Remove terminally deprecated constructor in GSSUtil
  • 940b053: 8259232: Bad JNI lookup during printing
  • df721f0: 8259291: Cleanup unnecessary local variables

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 6, 2021
coleenp
coleenp approved these changes Jan 6, 2021
Copy link
Contributor

@coleenp coleenp left a comment

Looks trivial too. Thanks!

@hseigel
Copy link
Member Author

@hseigel hseigel commented Jan 7, 2021

Thanks Lois and Coleen for the reviews.

/integrate

@openjdk openjdk bot closed this Jan 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 7, 2021

@hseigel Since your change was applied there have been 10 commits pushed to the master branch:

  • 3f9f86f: 8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006
  • 1c33847: 8259067: bootclasspath append takes out object lock
  • 0e6de4e: 8259339: AllocateUninitializedArray C2 intrinsic fails with void.class input
  • 81c0624: 8259354: Fix race condition in AbstractEventStream.nextThreadName
  • 227f99d: 8233555: [TESTBUG] JRadioButton tests failing on MacoS
  • 67c2211: 8259045: Exception message from saproc.dll is garbled on Windows with Japanese locale
  • 28e1f4d: 8247957: remove doclint support for HTML 4
  • 80544e4: 8250564: Remove terminally deprecated constructor in GSSUtil
  • 940b053: 8259232: Bad JNI lookup during printing
  • df721f0: 8259291: Cleanup unnecessary local variables

Your commit was automatically rebased without conflicts.

Pushed as commit f91f92d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants