8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out #19663

dfuch · 2024-06-11T17:07:38Z

Here is a trivial change that might fix intermittent failures in the test java/net/httpclient/whitebox/SSLTubeTestDriver.java.
The change makes sure the client connects using the loopback address instead of "localhost".

In case that does not fix the issue, some additional logging has been added to try to understand what's going on.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out (Bug - P4)

Reviewers

Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19663/head:pull/19663
$ git checkout pull/19663

Update a local copy of the PR:
$ git checkout pull/19663
$ git pull https://git.openjdk.org/jdk.git pull/19663/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19663

View PR using the GUI difftool:
$ git pr show -t 19663

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19663.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-06-11T17:08:24Z

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-06-11T17:09:07Z

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

81ca0ec: 8334028: HttpClient: NPE thrown from assert statement
bd750b6: 8319933: Disable tests for JDK-8280481 on Graal
c80e2eb: 8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory.
a0318bc: 8334077: Fix problem list entries for compiler tests
a7e4ab9: 8333730: ubsan: FieldIndices/libFieldIndicesTest.cpp:276:11: runtime error: null pointer passed as argument 2, which is declared to never be null
abbf45b: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'
bd046d9: 8222884: ConcurrentClassDescLookup.java times out intermittently
1c80ddb: 8333940: Ensure javax/swing/TestUngrab.java run on all platforms
a7205cc: 8333926: Shenandoah: Lower default immediate garbage threshold
56e8e60: 8330534: Update nsk/jdwp tests to use driver instead of othervm
... and 3 more: https://git.openjdk.org/jdk/compare/aaaa86b57172d45d1126c50efc270c6e49aba7a5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-06-11T17:09:37Z

@dfuch The following label will be automatically applied to this pull request:

net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-06-11T17:12:34Z

Webrevs

01: Full - Incremental (30291a7d)
00: Full (b1353b3b)

jaikiran · 2024-06-12T06:58:54Z

test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/SSLTubeTest.java

@@ -144,6 +146,7 @@ private void clientReader() {
                    publisher.submit(List.of(bb));
                }
            } catch (Throwable e) {
+                System.out.println("clientReader got exception: " + e);


Hello Daniel, I think since we are printing the stacktrace on the next line, it might be better to use System.err.println here so that this message to ends up in the System.err section like the stacktrace. Same suggestion for 2 more places in this PR where we are introducing such messages in the Throwable block.

I wanted to print this on System.out by design - to avoid the trace being lost among the many debug traces on System.err. What I'm interested mostly here is knowing whether the thread exited normally or with an error.
If you believe it's important enough I believe we could write both on System.out and System.err, but I specifically wanted it on System.out.

If you believe it's important enough I believe we could write both on System.out and System.err, but I specifically wanted it on System.out.

The current way you have it is fine. I didn't know the use of System.out was intentional.

jaikiran · 2024-06-12T06:59:31Z

test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/SSLTubeTest.java

@@ -212,14 +216,18 @@ private void serverLoopback() {
                        is.close();
                        os.close();
                        serverSock.close();
+                        System.out.println("serverLooback exiting normally");


Typo in the message, should have been serverLoopback .... Same in 1 other place.

jaikiran

The changes look OK to me. I have added a couple of trivial review comments inline.

dfuch · 2024-06-12T11:29:01Z

/integrate

openjdk · 2024-06-12T11:30:00Z

Going to push as commit 81083a0.
Since your change was applied there have been 13 commits pushed to the master branch:

81ca0ec: 8334028: HttpClient: NPE thrown from assert statement
bd750b6: 8319933: Disable tests for JDK-8280481 on Graal
c80e2eb: 8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory.
a0318bc: 8334077: Fix problem list entries for compiler tests
a7e4ab9: 8333730: ubsan: FieldIndices/libFieldIndicesTest.cpp:276:11: runtime error: null pointer passed as argument 2, which is declared to never be null
abbf45b: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'
bd046d9: 8222884: ConcurrentClassDescLookup.java times out intermittently
1c80ddb: 8333940: Ensure javax/swing/TestUngrab.java run on all platforms
a7205cc: 8333926: Shenandoah: Lower default immediate garbage threshold
56e8e60: 8330534: Update nsk/jdwp tests to use driver instead of othervm
... and 3 more: https://git.openjdk.org/jdk/compare/aaaa86b57172d45d1126c50efc270c6e49aba7a5...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-06-12T11:30:05Z

@dfuch Pushed as commit 81083a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

dfuch added 2 commits June 11, 2024 18:03

8299487

c26ece7

8299487

b1353b3

openjdk bot added the rfr Pull request is ready for review label Jun 11, 2024

openjdk bot added the net net-dev@openjdk.org label Jun 11, 2024

jaikiran reviewed Jun 12, 2024

View reviewed changes

jaikiran approved these changes Jun 12, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 12, 2024

Fixed typo

30291a7

jaikiran approved these changes Jun 12, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Jun 12, 2024

openjdk bot closed this Jun 12, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out #19663

8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out #19663

dfuch commented Jun 11, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jun 11, 2024

openjdk bot commented Jun 11, 2024 •

edited

Loading

openjdk bot commented Jun 11, 2024

mlbridge bot commented Jun 11, 2024 •

edited

Loading

jaikiran Jun 12, 2024

dfuch Jun 12, 2024 •

edited

Loading

jaikiran Jun 12, 2024

jaikiran Jun 12, 2024 •

edited

Loading

dfuch Jun 12, 2024

jaikiran left a comment

dfuch commented Jun 12, 2024

openjdk bot commented Jun 12, 2024

openjdk bot commented Jun 12, 2024

8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out #19663

8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out #19663

Conversation

dfuch commented Jun 11, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Jun 11, 2024

openjdk bot commented Jun 11, 2024 • edited Loading

openjdk bot commented Jun 11, 2024

mlbridge bot commented Jun 11, 2024 • edited Loading

Webrevs

jaikiran Jun 12, 2024

Choose a reason for hiding this comment

dfuch Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

jaikiran Jun 12, 2024

Choose a reason for hiding this comment

jaikiran Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

dfuch Jun 12, 2024

Choose a reason for hiding this comment

jaikiran left a comment

Choose a reason for hiding this comment

dfuch commented Jun 12, 2024

openjdk bot commented Jun 12, 2024

openjdk bot commented Jun 12, 2024

dfuch commented Jun 11, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Jun 11, 2024 •

edited

Loading

mlbridge bot commented Jun 11, 2024 •

edited

Loading

dfuch Jun 12, 2024 •

edited

Loading

jaikiran Jun 12, 2024 •

edited

Loading