Skip to content

8209092: Remove outdated wording from RC5ParameterSpec #19680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

blperez01
Copy link
Contributor

@blperez01 blperez01 commented Jun 12, 2024

The RC5ParameterSpec class description contains the following sentence: "This class can be used to initialize a Cipher object that implements the RC5 algorithm as supplied by RSA Security LLC, or any parties authorized by RSA Security."

The part "as supplied by RSA Security LLC, or any parties authorized by RSA Security." should be removed. We don't generally include information about 3rd-party JCA providers in the standard javadocs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8209092: Remove outdated wording from RC5ParameterSpec (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19680/head:pull/19680
$ git checkout pull/19680

Update a local copy of the PR:
$ git checkout pull/19680
$ git pull https://git.openjdk.org/jdk.git pull/19680/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19680

View PR using the GUI difftool:
$ git pr show -t 19680

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19680.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 12, 2024

👋 Welcome back blperez01! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 12, 2024

@blperez01 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8209092: Remove outdated wording from RC5ParameterSpec

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • 2c1da6c: 8332139: SymbolTableHash::Node allocations allocates twice the required memory
  • ba67ad6: 8319457: Update jpackage to support WiX v4 and v5 on Windows
  • 2c9185e: 8321308: AArch64: Fix matching predication for cbz/cbnz
  • 5a8a9fd: 8333382: [s390x] Enhance popcnt Instruction to use Z15 facilities
  • 81083a0: 8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out
  • 81ca0ec: 8334028: HttpClient: NPE thrown from assert statement
  • bd750b6: 8319933: Disable tests for JDK-8280481 on Graal
  • c80e2eb: 8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory.
  • a0318bc: 8334077: Fix problem list entries for compiler tests
  • a7e4ab9: 8333730: ubsan: FieldIndices/libFieldIndicesTest.cpp:276:11: runtime error: null pointer passed as argument 2, which is declared to never be null
  • ... and 19 more: https://git.openjdk.org/jdk/compare/96911537557dd95cd11598cd9a9f4e64e05e6aac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 12, 2024
@openjdk
Copy link

openjdk bot commented Jun 12, 2024

@blperez01 The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jun 12, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 12, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 12, 2024
@blperez01
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 12, 2024
@openjdk
Copy link

openjdk bot commented Jun 12, 2024

@blperez01
Your change (at version c62f311) is now ready to be sponsored by a Committer.

@seanjmullan
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 12, 2024

Going to push as commit 74468bc.
Since your change was applied there have been 30 commits pushed to the master branch:

  • b697b48: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup
  • 2c1da6c: 8332139: SymbolTableHash::Node allocations allocates twice the required memory
  • ba67ad6: 8319457: Update jpackage to support WiX v4 and v5 on Windows
  • 2c9185e: 8321308: AArch64: Fix matching predication for cbz/cbnz
  • 5a8a9fd: 8333382: [s390x] Enhance popcnt Instruction to use Z15 facilities
  • 81083a0: 8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out
  • 81ca0ec: 8334028: HttpClient: NPE thrown from assert statement
  • bd750b6: 8319933: Disable tests for JDK-8280481 on Graal
  • c80e2eb: 8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory.
  • a0318bc: 8334077: Fix problem list entries for compiler tests
  • ... and 20 more: https://git.openjdk.org/jdk/compare/96911537557dd95cd11598cd9a9f4e64e05e6aac...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 12, 2024
@openjdk openjdk bot closed this Jun 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 12, 2024
@openjdk
Copy link

openjdk bot commented Jun 12, 2024

@seanjmullan @blperez01 Pushed as commit 74468bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants