8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV

[zifeihan]

Hi, test/hotspot/jtreg/compiler/c2/cr7200264/TestIntVect.java fails without RVV after JDK-8332153 in fastdebug mode. see jbs issue for exception information.

As discussed on jbs, we prefixed the single letter cpu features with rv so that there would be no problem. And to synchronize the test cases.

After this patch, we can get cpu feature string like this:

----------System.out:(4/168)----------
WB.getCPUFeatures(): "rv64 rvi rvm rva rvf rvd rvc rvv"
CPUInfo.getAdditionalCPUInfo(): ""
CPUInfo.getFeatures(): [rv64, rvi, rvm, rva, rvf, rvd, rvc, rvv]
TEST PASSED

Testing

• All Tests related to all changes in this patch on Banana Pi BPI-F3 board (with RVV1.0) (fastdebug)
• All Tests related to all changes in this patch on SOPHON SG2042 (fastdebug)
• Run tier1-3 tests on SOPHON SG2042 (fastdebug)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV (Bug - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Hamlin Li (@Hamlin-Li - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19686/head:pull/19686
$ git checkout pull/19686

Update a local copy of the PR:
$ git checkout pull/19686
$ git pull https://git.openjdk.org/jdk.git pull/19686/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19686

View PR using the GUI difftool:
$ git pr show -t 19686

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19686.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV

Reviewed-by: fyang, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• 0d1080d: 8331117: [PPC64] secondary_super_cache does not scale well
• 113a2c0: 8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool'
• d751441: 8330586: GHA: Drop additional gcc/glibc packages installation for x86_32
• 5e09397: 8334222: exclude containers/cgroup/PlainRead.java
• 7b38bfe: 8333729: C2 SuperWord: remove some @requires usages in test/hotspot/jtreg/compiler/loopopts/superword
• 29b6392: 8334228: C2 SuperWord: fix JDK-24 regression in VPointer::cmp_for_sort after JDK-8325155
• 31e8deb: 8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved
• 8464ce6: 8332113: Update nsk.share.Log to be always verbose
• 548e95a: 8330702: Update failure handler to don't generate Error message if cores actions are empty
• dae0bda: 8334252: Verifier error for lambda declared in early construction context
• ... and 27 more: https://git.openjdk.org/jdk/compare/2c1da6c6fa2e50856ea71c0e266961171bee1037...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @Hamlin-Li) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@zifeihan The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (be044727)

[RealFYang]

Nice cleanup! Thanks!

Suggestion about the JBS title: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV

[zifeihan]

@Hamlin-Li : Are you OK with this change? This touches tests added by your previous PRs.

[Hamlin-Li]

Thanks for fixing the issue.
Some comments.

[Hamlin-Li]

Looks good.

[zifeihan]

@RealFYang @Hamlin-Li : Thanks for the review.
/integrate

[openjdk]

@zifeihan
Your change (at version be04472) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit ef7923e.
Since your change was applied there have been 37 commits pushed to the master branch:

• 0d1080d: 8331117: [PPC64] secondary_super_cache does not scale well
• 113a2c0: 8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool'
• d751441: 8330586: GHA: Drop additional gcc/glibc packages installation for x86_32
• 5e09397: 8334222: exclude containers/cgroup/PlainRead.java
• 7b38bfe: 8333729: C2 SuperWord: remove some @requires usages in test/hotspot/jtreg/compiler/loopopts/superword
• 29b6392: 8334228: C2 SuperWord: fix JDK-24 regression in VPointer::cmp_for_sort after JDK-8325155
• 31e8deb: 8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved
• 8464ce6: 8332113: Update nsk.share.Log to be always verbose
• 548e95a: 8330702: Update failure handler to don't generate Error message if cores actions are empty
• dae0bda: 8334252: Verifier error for lambda declared in early construction context
• ... and 27 more: https://git.openjdk.org/jdk/compare/2c1da6c6fa2e50856ea71c0e266961171bee1037...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @zifeihan Pushed as commit ef7923e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.