8259274: Increase timeout duration in sun/nio/ch/TestMaxCachedBufferSize.java

[bplb]

The change for JDK-8255913 integrated on 2020-11-05 reduced by half the number of iterations in TestMaxCachedBufferSize. As reported in JDK-8212812 on 2021-01-05, the test still failed due to a timeout after an elapsed time of 502738ms including timeout handling. The current timeout is 480000ms which represents the default timeout of 120s multiplied by the timeout factor of 4.

The present change proposes to increase the timeout by 25% to 150s. This should hopefully dispense with the ongoing test timeouts. As these timeouts have been observed primarily if not exclusively on decade-old MacPro5_1 machines, the timeout should not appreciably increase the overall CI test execution time.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259274: Increase timeout duration in sun/nio/ch/TestMaxCachedBufferSize.java

Reviewers

• Lance Andersen (@LanceAndersen - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1969/head:pull/1969
$ git checkout pull/1969

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• 2d
• awt
• beans
• build
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah
• sound
• swing

[bplb]

/label add nio

[openjdk]

@bplb
The nio label was successfully added.

[mlbridge]

Webrevs

• 00: Full (1c8bc97)

[LanceAndersen]

Seems like a reasonable means to address the issue

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259274: Increase timeout duration in sun/nio/ch/TestMaxCachedBufferSize.java

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 67c2211: 8259045: Exception message from saproc.dll is garbled on Windows with Japanese locale
• 28e1f4d: 8247957: remove doclint support for HTML 4
• 80544e4: 8250564: Remove terminally deprecated constructor in GSSUtil
• 940b053: 8259232: Bad JNI lookup during printing
• df721f0: 8259291: Cleanup unnecessary local variables
• d20d2fa: 8258143: Update --release 16 symbol information for JDK 16 build 30 or later
• 3be6e06: 8259312: VerifyCACerts.java fails as soneraclass2ca cert will expire in 90 days
• 722f236: 8259231: Epsilon: improve performance under contention during virtual space expansion
• f6cb8c5: 8258908: Remove JVM option CleanChunkPoolAsync
• c0540ff: 8231627: ThreadsListHandleInErrorHandlingTest.java fails in printing all threads
• ... and 8 more: https://git.openjdk.java.net/jdk/compare/4d3d59912d71a05865b87bb2579571fbda74b668...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

@bplb Since your change was applied there have been 29 commits pushed to the master branch:

• bc56541: 8256535: C2: randomize CCP processing order for stress testing
• d8ad630: 8258772: Some runtime/cds tests fail with +LogCompilation or +StressX
• 4ce83f2: 8039278: console.sh failed Automatically with exit code 1
• 2e99e28: 8213126: java/awt/Window/MainKeyWindow/TestMainKeyWindow.java time-out on mac10.13
• 8530ef0: 8259375: JvmtiExport::jni_Get/SetField_probe calls do not need ResetNoHandleMark
• f91f92d: 8259317: Remove JVM option BreakAtWarning
• 3f9f86f: 8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006
• 1c33847: 8259067: bootclasspath append takes out object lock
• 0e6de4e: 8259339: AllocateUninitializedArray C2 intrinsic fails with void.class input
• 81c0624: 8259354: Fix race condition in AbstractEventStream.nextThreadName
• ... and 19 more: https://git.openjdk.java.net/jdk/compare/4d3d59912d71a05865b87bb2579571fbda74b668...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2659bc4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.