New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253130: bug7072653.java failed "Popup window height ... is wrong" #197
Conversation
@@ -836,7 +836,6 @@ javax/swing/JMenuItem/4171437/bug4171437.java 8233641 macosx-all | |||
javax/swing/JMenu/4692443/bug4692443.java 8171998 macosx-all | |||
javax/swing/plaf/synth/7158712/bug7158712.java 8238720 windows-all | |||
javax/swing/plaf/basic/BasicComboPopup/JComboBoxPopupLocation/JComboBoxPopupLocation.java 8238720 windows-all | |||
javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java 8238720 windows-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked locally using different DPIs and on all our mach5 systems, all passed after the fix.
|
@mrserb The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me.
@mrserb This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 19 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge
|
/integrate |
@mrserb Since your change was applied there have been 19 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 1c84cfa. |
One more test which fails on the big screen, the number of items in the popup should be more than 100 to overlap the screen.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/197/head:pull/197
$ git checkout pull/197