Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253130: bug7072653.java failed "Popup window height ... is wrong" #197

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Sep 16, 2020

One more test which fails on the big screen, the number of items in the popup should be more than 100 to overlap the screen.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253130: bug7072653.java failed "Popup window height ... is wrong"

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/197/head:pull/197
$ git checkout pull/197

@@ -836,7 +836,6 @@ javax/swing/JMenuItem/4171437/bug4171437.java 8233641 macosx-all
javax/swing/JMenu/4692443/bug4692443.java 8171998 macosx-all
javax/swing/plaf/synth/7158712/bug7158712.java 8238720 windows-all
javax/swing/plaf/basic/BasicComboPopup/JComboBoxPopupLocation/JComboBoxPopupLocation.java 8238720 windows-all
javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java 8238720 windows-all
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked locally using different DPIs and on all our mach5 systems, all passed after the fix.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@mrserb The following label will be automatically applied to this pull request: swing.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Sep 16, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 16, 2020

Webrevs

Copy link
Contributor

@prsadhuk prsadhuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@mrserb This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253130: bug7072653.java failed "Popup window height ... is wrong"

Reviewed-by: psadhukhan
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 19 commits pushed to the master branch:

  • ce93cbc: 8253125: vmTestbase/nsk/stress/stack/stack017.java timed out
  • d250f9e: 8253244: Shenandoah: cleanup includes in Shenandoah root processor files
  • d38c97d: 8253207: enable problemlists jcheck's check
  • 671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
  • e5866aa: 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)
  • 1086713: 8253206: Enforce whitespace checking for additional source files
  • e2196f8: 8253162: Make frame::oops_do const
  • 300b851: 8253226: Shenandoah: remove unimplemented ShenandoahStrDedupQueue::verify
  • c781594: 8253224: Shenandoah: ShenandoahStrDedupQueue destructor calls virtual num_queues()
  • 33f8e70: 8253173: Print heap before and after GC lacks a newline
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/57f92d23b1049e7bfc1d54567757713ca1dd0f3c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate ce93cbce77e1f4baa52676826c8ae27d474360b6.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 16, 2020
@mrserb
Copy link
Member Author

mrserb commented Sep 16, 2020

/integrate

@openjdk openjdk bot closed this Sep 16, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@mrserb Since your change was applied there have been 19 commits pushed to the master branch:

  • ce93cbc: 8253125: vmTestbase/nsk/stress/stack/stack017.java timed out
  • d250f9e: 8253244: Shenandoah: cleanup includes in Shenandoah root processor files
  • d38c97d: 8253207: enable problemlists jcheck's check
  • 671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
  • e5866aa: 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)
  • 1086713: 8253206: Enforce whitespace checking for additional source files
  • e2196f8: 8253162: Make frame::oops_do const
  • 300b851: 8253226: Shenandoah: remove unimplemented ShenandoahStrDedupQueue::verify
  • c781594: 8253224: Shenandoah: ShenandoahStrDedupQueue destructor calls virtual num_queues()
  • 33f8e70: 8253173: Print heap before and after GC lacks a newline
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/57f92d23b1049e7bfc1d54567757713ca1dd0f3c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1c84cfa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
2 participants