New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8259350: Add some internal debugging APIs to the debug agent #1970
Conversation
|
@plummercj The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Ping! Still need 2 reviews. |
@plummercj This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 163 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
@plummercj Since your change was applied there have been 163 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit d18d26e. |
This PR adds some APIs that are useful when debugging the debug agent. They can be called from gdb or from other parts of the debug agent. They mostly do things like dumping internal data structures that are tedious to dump or iterate over in gdb. I developed them while working on loom and found them useful.
Note that
dumpThreadList()
anddumpThread()
are not exported from threadControl.c because the argument types are only visible within threadControl.c.I debated whether to bracket all these APIs with
#ifdef DEBUG
. In the end I decided to in order to make it clear they are only meant for debugging purposes. If you temporarily need them with a product build, you can always modify the code to include them. I could be persuaded#ifdef DEBUG
though.Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1970/head:pull/1970
$ git checkout pull/1970