Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333827: JDK 23 RDP1 L10n resource files update #19713

Closed

Conversation

DamonGuy
Copy link
Contributor

@DamonGuy DamonGuy commented Jun 13, 2024

Hi all,

This pull request contains a backport of commit c4702ca8 from the openjdk/jdk repository.

The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and was reviewed by Alisen Chung, Justin Lu, Naoto Sato, Joe Wang, Pavel Rappo, Chris Plummer, Alexey Semenyuk and Phil Race.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8333827: JDK 23 RDP1 L10n resource files update (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19713/head:pull/19713
$ git checkout pull/19713

Update a local copy of the PR:
$ git checkout pull/19713
$ git pull https://git.openjdk.org/jdk.git pull/19713/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19713

View PR using the GUI difftool:
$ git pr show -t 19713

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19713.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2024

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 13, 2024

@DamonGuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333827: JDK 23 RDP1 L10n resource files update

Reviewed-by: jlu, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk23 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport c4702ca8c026e2d265aca0126fd3fb7bc5bb392a 8333827: JDK 23 RDP1 L10n resource files update Jun 13, 2024
@openjdk
Copy link

openjdk bot commented Jun 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 13, 2024
@openjdk
Copy link

openjdk bot commented Jun 13, 2024

@DamonGuy The following labels will be automatically applied to this pull request:

  • client
  • compiler
  • core-libs
  • javadoc
  • kulla
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org serviceability serviceability-dev@openjdk.org client client-libs-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org kulla kulla-dev@openjdk.org labels Jun 13, 2024
Copy link
Member

@justin-curtis-lu justin-curtis-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean backport of L10n resource drop required for JDK23

@mlbridge
Copy link

mlbridge bot commented Jun 13, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 13, 2024
@DamonGuy
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 13, 2024

Going to push as commit a796445.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 13, 2024
@openjdk openjdk bot closed this Jun 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 13, 2024
@openjdk
Copy link

openjdk bot commented Jun 13, 2024

@DamonGuy Pushed as commit a796445.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean client client-libs-dev@openjdk.org compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org kulla kulla-dev@openjdk.org serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants