-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8333827: JDK 23 RDP1 L10n resource files update #19713
8333827: JDK 23 RDP1 L10n resource files update #19713
Conversation
👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into |
@DamonGuy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
@DamonGuy The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean backport of L10n resource drop required for JDK23
/integrate |
Going to push as commit a796445. |
Hi all,
This pull request contains a backport of commit c4702ca8 from the openjdk/jdk repository.
The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and was reviewed by Alisen Chung, Justin Lu, Naoto Sato, Joe Wang, Pavel Rappo, Chris Plummer, Alexey Semenyuk and Phil Race.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19713/head:pull/19713
$ git checkout pull/19713
Update a local copy of the PR:
$ git checkout pull/19713
$ git pull https://git.openjdk.org/jdk.git pull/19713/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19713
View PR using the GUI difftool:
$ git pr show -t 19713
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19713.diff
Webrev
Link to Webrev Comment