Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out #19717

Closed

Conversation

dfuch
Copy link
Member

@dfuch dfuch commented Jun 14, 2024

Clean backport of a small test fix that should avoid some intermittent failures in the CI.

The mainline fix PR can be seen here: PR: https://git.openjdk.org/jdk/pull/19663


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19717/head:pull/19717
$ git checkout pull/19717

Update a local copy of the PR:
$ git checkout pull/19717
$ git pull https://git.openjdk.org/jdk.git pull/19717/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19717

View PR using the GUI difftool:
$ git pr show -t 19717

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19717.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2024

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 14, 2024

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the jdk23 branch:

  • 48997f5: 8326715: ZGC: RunThese24H fails with ExitCode 139 during shutdown
  • 4e3bfc9: 8211847: [aix] java/lang/ProcessHandle/InfoTest.java fails: "reported cputime less than expected"
  • d0b4f9b: 8334222: exclude containers/cgroup/PlainRead.java
  • cb3c45a: 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fails: read times out

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk23 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 81083a0e10d9c92f5247ae256e170709014b596b 8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out Jun 14, 2024
@openjdk
Copy link

openjdk bot commented Jun 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 14, 2024
@openjdk
Copy link

openjdk bot commented Jun 14, 2024

@dfuch The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Jun 14, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 14, 2024

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-only change and a clean backport. Looks good to me for 23.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 17, 2024
@dfuch
Copy link
Member Author

dfuch commented Jun 17, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

Going to push as commit 86fcbe0.
Since your change was applied there have been 4 commits pushed to the jdk23 branch:

  • 48997f5: 8326715: ZGC: RunThese24H fails with ExitCode 139 during shutdown
  • 4e3bfc9: 8211847: [aix] java/lang/ProcessHandle/InfoTest.java fails: "reported cputime less than expected"
  • d0b4f9b: 8334222: exclude containers/cgroup/PlainRead.java
  • cb3c45a: 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fails: read times out

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 17, 2024
@openjdk openjdk bot closed this Jun 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 17, 2024
@openjdk
Copy link

openjdk bot commented Jun 17, 2024

@dfuch Pushed as commit 86fcbe0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated net net-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants