8334293: G1: Refactor G1ConcurrentMark::update_top_at_rebuild_start

[albertnetymk]

Simple removing an always true condition.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8334293: G1: Refactor G1ConcurrentMark::update_top_at_rebuild_start (Enhancement - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19718/head:pull/19718
$ git checkout pull/19718

Update a local copy of the PR:
$ git checkout pull/19718
$ git pull https://git.openjdk.org/jdk.git pull/19718/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19718

View PR using the GUI difftool:
$ git pr show -t 19718

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19718.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334293: G1: Refactor G1ConcurrentMark::update_top_at_rebuild_start

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 99fefec: 8331431: Update to use jtreg 7.4
• 0199fee: 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]'
• e95f092: 8333964: RISC-V: C2: Check "requires_strict_order" flag for floating-point add reduction
• ba5a467: 8332854: Unable to build openjdk with --with-harfbuzz=system
• 801bf15: 8332105: Exploded JDK does not include CDS
• c94af6f: 8333962: Obsolete OldSize
• cdf22b1: 8326715: ZGC: RunThese24H fails with ExitCode 139 during shutdown
• ef7923e: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV
• 0d1080d: 8331117: [PPC64] secondary_super_cache does not scale well
• 113a2c0: 8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool'
• ... and 10 more: https://git.openjdk.org/jdk/compare/cc64aeac47917f20a6d70e9796f0de9aa165ce62...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (340a08df)

[albertnetymk]

Thanks for review.

/integrate

[openjdk]

Going to push as commit 0665195.
Since your change was applied there have been 20 commits pushed to the master branch:

• 99fefec: 8331431: Update to use jtreg 7.4
• 0199fee: 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]'
• e95f092: 8333964: RISC-V: C2: Check "requires_strict_order" flag for floating-point add reduction
• ba5a467: 8332854: Unable to build openjdk with --with-harfbuzz=system
• 801bf15: 8332105: Exploded JDK does not include CDS
• c94af6f: 8333962: Obsolete OldSize
• cdf22b1: 8326715: ZGC: RunThese24H fails with ExitCode 139 during shutdown
• ef7923e: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV
• 0d1080d: 8331117: [PPC64] secondary_super_cache does not scale well
• 113a2c0: 8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool'
• ... and 10 more: https://git.openjdk.org/jdk/compare/cc64aeac47917f20a6d70e9796f0de9aa165ce62...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 0665195.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.