Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006 #1972

Closed
wants to merge 2 commits into from

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Jan 7, 2021

Hello, for a while the AIX build fails with the following error in the harfbuzz build
1500-004: (U) INTERNAL COMPILER ERROR while compiling OT::MarkBasePosFormat1::collect_variation_indices(hb_collect_variation_indices_context_t *) const.
Compilation ended. Contact your Service Representative and provide the following information: GRARNN: gr29643 is used before it is defined.

This xlc 16 version is used for compiling
bash-4.4$ xlc -qversion
IBM XL C/C++ for AIX, V16.1.0 (5725-C72, 5765-J12)
Version: 16.01.0000.0006

Solution by IBM compiler support is to use "-qdebug=necan", this effectively turns off an optimisation called "Early Re-canonizing" on the harfbuzz lib.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1972/head:pull/1972
$ git checkout pull/1972

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 7, 2021

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jan 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 7, 2021

@MBaesken The following labels will be automatically applied to this pull request:

  • 2d
  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 7, 2021

Webrevs

Loading

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Hi Matthias,

looks good to me in principal. I would spell out the abbreviation ICE, though, otherwise somebody reading this later could have difficulties to grok it ;-)

Thanks
Christoph

Loading

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Maybe better:
Early re-canonizing has to be disabled to workaround an internal XlC compiler error when building libharfbuzz
?

Loading

Copy link
Contributor

@RealCLanger RealCLanger left a comment

LGTM now :)

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 7, 2021

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006

Reviewed-by: clanger, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jan 7, 2021
@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Jan 7, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jan 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 7, 2021

@MBaesken Since your change was applied there have been 2 commits pushed to the master branch:

  • 1c33847: 8259067: bootclasspath append takes out object lock
  • 0e6de4e: 8259339: AllocateUninitializedArray C2 intrinsic fails with void.class input

Your commit was automatically rebased without conflicts.

Pushed as commit 3f9f86f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@MBaesken MBaesken deleted the JDK-8258484 branch Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants