8330699: Obsolete -XX:+UseEmptySlotsInSupers

[coleenp]

Remove code to not use empty slots in supers.
Tested with tier1-4.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8330699: Obsolete -XX:+UseEmptySlotsInSupers (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer) ⚠️ Review applies to 4d74804a
• Frederic Parain (@fparain - Reviewer) ⚠️ Review applies to 4d74804a
• @abdelhak-zaaim (no known openjdk.org user name / role) ⚠️ Review applies to 4d74804a
• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to da791744

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19720/head:pull/19720
$ git checkout pull/19720

Update a local copy of the PR:
$ git checkout pull/19720
$ git pull https://git.openjdk.org/jdk.git pull/19720/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19720

View PR using the GUI difftool:
$ git pr show -t 19720

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19720.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330699: Obsolete -XX:+UseEmptySlotsInSupers

Reviewed-by: shade, fparain, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full (70f11801)
• 01: Full - Incremental (da791744)
• 00: Full (4d74804a)

[shipilev]

Forgot to update special_jvm_flags, I think?
EDIT: Ah no, it should stay to fail cleanly, nevermind.

[shipilev]

Looks fine.

[coleenp]

Forgot to update special_jvm_flags, I think?

That's removed when the flag is removed in the next release.

[fparain]

LGTM
Thank you for the removal of this code.

[dholmes-ora]

Looks good. But the flag table entry in arguments.cpp should be moved from the deprecated section to the obsolete section. Also the test

./test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java

needs updating.

Thanks.

[coleenp]

There's no mention of this option in the VMDeprecatedOptions.java test. It was removed in:
8330182: Start of release updates for JDK 24

[dholmes-ora]

There's no mention of this option in the VMDeprecatedOptions.java test. It was removed in: 8330182: Start of release updates for JDK 24

Sorry my bad. I was looking in an out-of-date branch

[dholmes-ora]

Thanks for the update. Sorry for the delay.

[openjdk]

@coleenp this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout supers
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[coleenp]

Thank you Aleksey, Fred and David.
/integrate

[openjdk]

Going to push as commit 4b4a483.
Since your change was applied there have been 29 commits pushed to the master branch:

• 187710e: 8333300: [JVMCI] add support for generational ZGC
• de8ee97: 8334333: MissingResourceCauseTestRun.java fails if run by root
• 265a0f5: 8334490: Normalize string with locale invariant toLowerCase()
• 1b1dba8: 8333358: java/io/IO/IO.java test fails intermittently
• a81e1bf: 8332252: Clean up vmTestbase/vm/share
• 99e4d77: 8333117: Remove support of remote and manual debuggee launchers
• 9ef86da: 8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4
• 001d686: 8332587: RISC-V: secondary_super_cache does not scale well
• 5cad0b4: 8322708: Global HTML attributes are not allowed
• 6420846: 8334396: RISC-V: verify perf of ReverseBytesI/L
• ... and 19 more: https://git.openjdk.org/jdk/compare/e965d70a7425bec78620a2ca8bfaca3c392edf6a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 4b4a483.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.