Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259368: Zero: UseCompressedClassPointers does not depend on UseCompressedOops #1973

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 7, 2021

JDK-8241825 decoupled UseCompressedClassPointers and UseCompressedOops, and introduced COMPRESSED_CLASS_POINTERS_DEPENDS_ON_COMPRESSED_OOPS that platforms can set to say if their generated code is ready for this decoupling.

Zero defaults to true for that flag, meaning the flags are still coupled. But there is not actual coupling: Zero delegates all this work to VM code, which handles everything correctly. This makes at least one test fail with Zero:

$ CONF=linux-x86_64-zero-fastdebug make exploded-test TEST=runtime/CompressedOops/CompressedClassPointers.java
java.lang.RuntimeException: 'Narrow klass base: 0x0000000000000000' missing from stdout/stderr
...

Additional testing:

  • Linux x86_64 Zero runtime/CompressedOops/ tests

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259368: Zero: UseCompressedClassPointers does not depend on UseCompressedOops

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1973/head:pull/1973
$ git checkout pull/1973

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 7, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 7, 2021
@openjdk
Copy link

openjdk bot commented Jan 7, 2021

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jan 7, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 7, 2021

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Jan 7, 2021

/label remove hotspot-compiler
/label add hotspot-runtime

@openjdk openjdk bot removed the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jan 7, 2021
@openjdk
Copy link

openjdk bot commented Jan 7, 2021

@shipilev
The hotspot-compiler label was successfully removed.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 7, 2021
@openjdk
Copy link

openjdk bot commented Jan 7, 2021

@shipilev
The hotspot-runtime label was successfully added.

@openjdk
Copy link

openjdk bot commented Jan 7, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259368: Zero: UseCompressedClassPointers does not depend on UseCompressedOops

Reviewed-by: aph, zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 7, 2021
Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Looks good. Pleas update copyright year.

@shipilev
Copy link
Member Author

shipilev commented Jan 11, 2021

/integrate

@openjdk openjdk bot closed this Jan 11, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 11, 2021
@openjdk
Copy link

openjdk bot commented Jan 11, 2021

@shipilev Since your change was applied there have been 85 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 18a37f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8259368-zero-use-compressed-oops branch Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants