Skip to content

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Jun 16, 2024

Verified on Ubuntu 24.04


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332854: Unable to build openjdk with --with-harfbuzz=system (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19739/head:pull/19739
$ git checkout pull/19739

Update a local copy of the PR:
$ git checkout pull/19739
$ git pull https://git.openjdk.org/jdk.git pull/19739/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19739

View PR using the GUI difftool:
$ git pr show -t 19739

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19739.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2024

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 16, 2024

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332854: Unable to build openjdk with --with-harfbuzz=system

Reviewed-by: jwaters, erikj, jdv, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • cdf22b1: 8326715: ZGC: RunThese24H fails with ExitCode 139 during shutdown
  • ef7923e: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV
  • 0d1080d: 8331117: [PPC64] secondary_super_cache does not scale well
  • 113a2c0: 8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool'
  • d751441: 8330586: GHA: Drop additional gcc/glibc packages installation for x86_32
  • 5e09397: 8334222: exclude containers/cgroup/PlainRead.java
  • 7b38bfe: 8333729: C2 SuperWord: remove some @requires usages in test/hotspot/jtreg/compiler/loopopts/superword
  • 29b6392: 8334228: C2 SuperWord: fix JDK-24 regression in VPointer::cmp_for_sort after JDK-8325155
  • 31e8deb: 8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8332854 8332854: Unable to build openjdk with --with-harfbuzz=system Jun 16, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 16, 2024
@openjdk
Copy link

openjdk bot commented Jun 16, 2024

@prrace The following labels will be automatically applied to this pull request:

  • build
  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org client client-libs-dev@openjdk.org labels Jun 16, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 17, 2024
Copy link
Member

@jayathirthrao jayathirthrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked build code and looks like by default bundled harfbuzz library is used. With --with-harfbuzz=system, we use system provided harfbuzz lib.
Change looks good to me.

@prrace
Copy link
Contributor Author

prrace commented Jun 17, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

Going to push as commit ba5a467.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 801bf15: 8332105: Exploded JDK does not include CDS
  • c94af6f: 8333962: Obsolete OldSize
  • cdf22b1: 8326715: ZGC: RunThese24H fails with ExitCode 139 during shutdown
  • ef7923e: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV
  • 0d1080d: 8331117: [PPC64] secondary_super_cache does not scale well
  • 113a2c0: 8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool'
  • d751441: 8330586: GHA: Drop additional gcc/glibc packages installation for x86_32
  • 5e09397: 8334222: exclude containers/cgroup/PlainRead.java
  • 7b38bfe: 8333729: C2 SuperWord: remove some @requires usages in test/hotspot/jtreg/compiler/loopopts/superword
  • 29b6392: 8334228: C2 SuperWord: fix JDK-24 regression in VPointer::cmp_for_sort after JDK-8325155
  • ... and 1 more: https://git.openjdk.org/jdk/compare/8464ce6db5cbd5d50ac2a2bcba905b7255f510f5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 17, 2024
@openjdk openjdk bot closed this Jun 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 17, 2024
@openjdk
Copy link

openjdk bot commented Jun 17, 2024

@prrace Pushed as commit ba5a467.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

5 participants