Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253910: UseCompressedClassPointers depends on UseCompressedOops in vmError.cpp #1974

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Jan 7, 2021

As noted in the bug report, there are places in vmError.cpp, where information on compressed classes is only printed if compressed oops are enabled. After JDK-8241825 both features should be independent. In addition to 2 reported places, we also need to print the setting in JVM modeline.

Sample outputs:

Command Line: Crash
...
# Java VM: OpenJDK 64-Bit Server VM (fastdebug 17-internal+0-adhoc.shade.jdk, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
...
VM Mutex/Monitor currently owned by a thread: None

Heap address: 0x0000000082000000, size: 30688 MB, Compressed Oops mode: Zero based, Oop shift amount: 3

CDS archive(s) mapped at: [0x0000000800000000-0x0000000800c5c000-0x0000000800c5c000), size 12959744, SharedBaseAddress: 0x0000000800000000, ArchiveRelocationMode: 0.
Compressed class space mapped at: 0x0000000801000000-0x0000000841000000, reserved size: 1073741824
Narrow klass base: 0x0000000800000000, Narrow klass shift: 3, Narrow klass range: 0x100000000

GC Precious Log:
Command Line: -XX:-UseCompressedOops Crash
...
# Java VM: OpenJDK 64-Bit Server VM (fastdebug 17-internal+0-adhoc.shade.jdk, mixed mode, sharing, tiered, compressed class ptrs, g1 gc, linux-amd64)
...
VM Mutex/Monitor currently owned by a thread: None

CDS archive(s) mapped at: [0x0000000800000000-0x0000000800c2f000-0x0000000800c2f000), size 12775424, SharedBaseAddress: 0x0000000800000000, ArchiveRelocationMode: 0.
Compressed class space mapped at: 0x0000000801000000-0x0000000841000000, reserved size: 1073741824
Narrow klass base: 0x0000000800000000, Narrow klass shift: 3, Narrow klass range: 0x100000000

GC Precious Log:
...
Command Line: -XX:-UseCompressedOops -XX:-UseCompressedClassPointers Crash
...
# Java VM: OpenJDK 64-Bit Server VM (fastdebug 17-internal+0-adhoc.shade.jdk, mixed mode, tiered, g1 gc, linux-amd64)
...
VM Mutex/Monitor currently owned by a thread: None

GC Precious Log:
...

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253910: UseCompressedClassPointers depends on UseCompressedOops in vmError.cpp

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1974/head:pull/1974
$ git checkout pull/1974

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 7, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 7, 2021

@shipilev The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 7, 2021

Webrevs

Copy link
Contributor

@reinrich reinrich left a comment

The change looks good to me. Thanks for fixing.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

That all seems fine to me.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Jan 8, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253910: UseCompressedClassPointers depends on UseCompressedOops in vmError.cpp

Reviewed-by: rrich, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 8, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Jan 11, 2021

/integrate

@openjdk openjdk bot closed this Jan 11, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@shipilev Since your change was applied there have been 84 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit a03e22b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8253910-vmError-compressed-class-ptrs branch Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants