8332524: Instead of printing "TLSv1.3," it is showing "TLS13"

[nibjen]

While doing SSL/TLS connection, start the Client with protocol TLSv1.2 and Server with protocol TLSv1.3. During handshake process, the exception shows as "javax.net.ssl.SSLHandshakeException: The client supported protocol versions [TLSv1.2] are not accepted by server preferences [TLS13]", where printing as TLS13 and not formatted to TLSv1.3.

After the given change, the protocol version is correctly printing:
javax.net.ssl.SSLHandshakeException: (protocol_version) The client supported protocol versions [TLSv1.2] are not accepted by server preferences [TLSv1.3]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8332524: Instead of printing "TLSv1.3," it is showing "TLS13" (Bug - P4)

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19749/head:pull/19749
$ git checkout pull/19749

Update a local copy of the PR:
$ git checkout pull/19749
$ git pull https://git.openjdk.org/jdk.git pull/19749/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19749

View PR using the GUI difftool:
$ git pr show -t 19749

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19749.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back nibjen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@nibjen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332524: Instead of printing "TLSv1.3," it is showing "TLS13"

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

• fa401f3: 8333805: Replaying compilation with null static final fields results in a crash
• 472b935: 8334332: TestIOException.java fails if run by root
• 614b99a: 8334442: Temporarily disable return type assertion to reduce noise in testing
• d4c1373: 8334043: VerifyError when inner class is accessed in prologue
• b42fe86: 8334097: Parallel: Obsolete HeapFirstMaximumCompactionCount
• 0665195: 8334293: G1: Refactor G1ConcurrentMark::update_top_at_rebuild_start
• 99fefec: 8331431: Update to use jtreg 7.4
• 0199fee: 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]'
• e95f092: 8333964: RISC-V: C2: Check "requires_strict_order" flag for floating-point add reduction
• ba5a467: 8332854: Unable to build openjdk with --with-harfbuzz=system
• ... and 44 more: https://git.openjdk.org/jdk/compare/5a8a9fdfa599e8939a5c6675883a92c869474979...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@nibjen The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (53237990)

[seanjmullan]

The JBS issue should have a noreg label, probably noreg-trivial is ok. Looks good otherwise.

[openjdk]

⚠️ @nibjen the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8332524
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[nibjen]

/integrate

[openjdk]

@nibjen
Your change (at version 5323799) is now ready to be sponsored by a Committer.

[seanjmullan]

/sponsor

[openjdk]

Going to push as commit e681b4e.
Since your change was applied there have been 54 commits pushed to the master branch:

• fa401f3: 8333805: Replaying compilation with null static final fields results in a crash
• 472b935: 8334332: TestIOException.java fails if run by root
• 614b99a: 8334442: Temporarily disable return type assertion to reduce noise in testing
• d4c1373: 8334043: VerifyError when inner class is accessed in prologue
• b42fe86: 8334097: Parallel: Obsolete HeapFirstMaximumCompactionCount
• 0665195: 8334293: G1: Refactor G1ConcurrentMark::update_top_at_rebuild_start
• 99fefec: 8331431: Update to use jtreg 7.4
• 0199fee: 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]'
• e95f092: 8333964: RISC-V: C2: Check "requires_strict_order" flag for floating-point add reduction
• ba5a467: 8332854: Unable to build openjdk with --with-harfbuzz=system
• ... and 44 more: https://git.openjdk.org/jdk/compare/5a8a9fdfa599e8939a5c6675883a92c869474979...master

Your commit was automatically rebased without conflicts.

[openjdk]

@seanjmullan @nibjen Pushed as commit e681b4e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.