Skip to content

8334399: [JVMCI] Implement JVMCICompiler::is_intrinsic_supported #19753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mur47x111
Copy link
Contributor

@mur47x111 mur47x111 commented Jun 17, 2024

Implement JVMCICompiler::is_intrinsic_supported by consulting jdk/vm/ci/runtime/JVMCICompiler.isIntrinsicSupported. This enables WhiteBox-based tests that depend on the result of this method, e.g., compiler/codegen/aes/TestAESMain.java, on Graal.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8334399: [JVMCI] Implement JVMCICompiler::is_intrinsic_supported (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19753/head:pull/19753
$ git checkout pull/19753

Update a local copy of the PR:
$ git checkout pull/19753
$ git pull https://git.openjdk.org/jdk.git pull/19753/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19753

View PR using the GUI difftool:
$ git pr show -t 19753

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19753.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2024

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334399: [JVMCI] Implement JVMCICompiler::is_intrinsic_supported

Reviewed-by: dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 6f860f8: 8334430: Clean up nativeInst_x86.*
  • 8bc2fbe: 8333769: Pretouching tests dont test pretouching
  • 91bd85d: 8333854: IllegalAccessError with proxies after JDK-8332457
  • e681b4e: 8332524: Instead of printing "TLSv1.3," it is showing "TLS13"
  • fa401f3: 8333805: Replaying compilation with null static final fields results in a crash
  • 472b935: 8334332: TestIOException.java fails if run by root
  • 614b99a: 8334442: Temporarily disable return type assertion to reduce noise in testing
  • d4c1373: 8334043: VerifyError when inner class is accessed in prologue
  • b42fe86: 8334097: Parallel: Obsolete HeapFirstMaximumCompactionCount
  • 0665195: 8334293: G1: Refactor G1ConcurrentMark::update_top_at_rebuild_start
  • ... and 6 more: https://git.openjdk.org/jdk/compare/cdf22b13204456b589349500bef0e9d48af44e83...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 17, 2024
@openjdk
Copy link

openjdk bot commented Jun 17, 2024

@mur47x111 The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Jun 17, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2024

Webrevs

@mur47x111 mur47x111 changed the title 8334399: [JVMCI] Implement JVMCICompiler::is_intrinsic_supported. 8334399: [JVMCI] Implement JVMCICompiler::is_intrinsic_supported Jun 17, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 18, 2024
@mur47x111
Copy link
Contributor Author

Thanks for the review!

/integrate

@openjdk
Copy link

openjdk bot commented Jun 19, 2024

Going to push as commit 2165a05.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 48621ae: 8331168: Introduce PredicateEntryIterator to iterate through predicate entries
  • e227c7e: 8334258: Compiler erronousely allows access to instance variable in argument expression of a constructor invocation
  • 2ce85d9: 8291472: [macos] jawt 1.4 lock/unlock not supported
  • e965d70: 8333876: C2 SuperWord: regression after JDK-8325155: failed: internal connection
  • 6f860f8: 8334430: Clean up nativeInst_x86.*
  • 8bc2fbe: 8333769: Pretouching tests dont test pretouching
  • 91bd85d: 8333854: IllegalAccessError with proxies after JDK-8332457
  • e681b4e: 8332524: Instead of printing "TLSv1.3," it is showing "TLS13"
  • fa401f3: 8333805: Replaying compilation with null static final fields results in a crash
  • 472b935: 8334332: TestIOException.java fails if run by root
  • ... and 10 more: https://git.openjdk.org/jdk/compare/cdf22b13204456b589349500bef0e9d48af44e83...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 19, 2024
@openjdk openjdk bot closed this Jun 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 19, 2024
@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@mur47x111 Pushed as commit 2165a05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants