Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331675: gtest CollectorPolicy.young_min_ergo_vm fails after 8272364 #19759

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jun 18, 2024

Hi all,

This pull request contains a backport of JDK-8331675, commit badf1cb9 from the openjdk/jdk repository.

The commit being backported was authored by Albert Mingkun Yang on 11 Jun 2024 and was reviewed by Thomas Schatzl, Zhengyu Gu and Guoxiong Li.

It removes a questionable test that was even failing on PowerPC.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8331675: gtest CollectorPolicy.young_min_ergo_vm fails after 8272364

Issue

  • JDK-8331675: gtest CollectorPolicy.young_min_ergo_vm fails after 8272364 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19759/head:pull/19759
$ git checkout pull/19759

Update a local copy of the PR:
$ git checkout pull/19759
$ git pull https://git.openjdk.org/jdk.git pull/19759/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19759

View PR using the GUI difftool:
$ git pr show -t 19759

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19759.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2024

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331675: gtest CollectorPolicy.young_min_ergo_vm fails after 8272364

Reviewed-by: ayang, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk23 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport badf1cb9ce9dcae6cca92046f7cc1231067ca799 8331675: gtest CollectorPolicy.young_min_ergo_vm fails after 8272364 Jun 18, 2024
@openjdk
Copy link

openjdk bot commented Jun 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 18, 2024
@openjdk
Copy link

openjdk bot commented Jun 18, 2024

@RealCLanger The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jun 18, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 18, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 18, 2024
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting!

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

Going to push as commit a4b4925.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 18, 2024
@openjdk openjdk bot closed this Jun 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 18, 2024
@openjdk
Copy link

openjdk bot commented Jun 18, 2024

@RealCLanger Pushed as commit a4b4925.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants