Skip to content

8309821: Link to hidden classes section in Class specification for Class::isHidden #19781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Jun 19, 2024

Simple doc improvement.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309821: Link to hidden classes section in Class specification for Class::isHidden (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19781/head:pull/19781
$ git checkout pull/19781

Update a local copy of the PR:
$ git checkout pull/19781
$ git pull https://git.openjdk.org/jdk.git pull/19781/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19781

View PR using the GUI difftool:
$ git pr show -t 19781

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19781.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2024

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309821: Link to hidden classes section in Class specification for Class::isHidden

Reviewed-by: iris, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 50bed6c: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager
  • 7b3a96d: 8334488: Improve error for illegal early access from nested class
  • 07ebda5: 8334215: serviceability/dcmd/thread/PrintMountedVirtualThread.java failing with JTREG_TEST_THREAD_FACTORY=Virtual
  • 2165a05: 8334399: [JVMCI] Implement JVMCICompiler::is_intrinsic_supported
  • 48621ae: 8331168: Introduce PredicateEntryIterator to iterate through predicate entries
  • e227c7e: 8334258: Compiler erronousely allows access to instance variable in argument expression of a constructor invocation
  • 2ce85d9: 8291472: [macos] jawt 1.4 lock/unlock not supported

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8309821: Link to hidden classes section in Class specification for Class::isHidden 8309821: Link to hidden classes section in Class specification for Class::isHidden Jun 19, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 19, 2024
@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 19, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 19, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 19, 2024
@jddarcy
Copy link
Member Author

jddarcy commented Jun 19, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 19, 2024

Going to push as commit 4e58d8c.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 78682fe: 8329288: Update Visual Studio visibility support for POSIX functions
  • bcf4bb4: 8333344: JMX attaching of Subject does not work when security manager not allowed
  • 856931d: 8304732: jdk/jfr/api/consumer/recordingstream/TestStop.java failed again with "Expected outer stream to have 3 events"
  • 01ee424: 8294960: Convert java.base/java.lang.invoke package to use the Classfile API to generate lambdas and method handles
  • 50bed6c: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager
  • 7b3a96d: 8334488: Improve error for illegal early access from nested class
  • 07ebda5: 8334215: serviceability/dcmd/thread/PrintMountedVirtualThread.java failing with JTREG_TEST_THREAD_FACTORY=Virtual
  • 2165a05: 8334399: [JVMCI] Implement JVMCICompiler::is_intrinsic_supported
  • 48621ae: 8331168: Introduce PredicateEntryIterator to iterate through predicate entries
  • e227c7e: 8334258: Compiler erronousely allows access to instance variable in argument expression of a constructor invocation
  • ... and 1 more: https://git.openjdk.org/jdk/compare/e965d70a7425bec78620a2ca8bfaca3c392edf6a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 19, 2024
@openjdk openjdk bot closed this Jun 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 19, 2024
@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@jddarcy Pushed as commit 4e58d8c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8309821 branch October 26, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants