Skip to content

8334502: gtest/GTestWrapper.java fails on armhf due to LogDecorations.iso8601_utctime_test #19782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

8334502: gtest/GTestWrapper.java fails on armhf due to LogDecorations.iso8601_utctime_test #19782

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ceaa32
use int instead of time_t to print timezone info
vpa1977 Jun 19, 2024
e9fb608
Merge remote-tracking branch 'origin/master' into fix_time_t
vpa1977 Jul 12, 2024
ff97727
add static_cast<int> to avoid -Wconversion warnings.
vpa1977 Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/hotspot/share/runtime/os.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,9 @@ char* os::iso8601_time(jlong milliseconds_since_19700101, char* buffer, size_t b
abs_local_to_UTC = -(abs_local_to_UTC);
}
// Convert time zone offset seconds to hours and minutes.
const time_t zone_hours = (abs_local_to_UTC / seconds_per_hour);
const time_t zone_min =
((abs_local_to_UTC % seconds_per_hour) / seconds_per_minute);
const int zone_hours = static_cast<int>(abs_local_to_UTC / seconds_per_hour);
const int zone_min =
static_cast<int>((abs_local_to_UTC % seconds_per_hour) / seconds_per_minute);

// Print an ISO 8601 date and time stamp into the buffer
const int year = 1900 + time_struct.tm_year;
Expand Down