8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4 #19788

kumarabhi006 · 2024-06-19T08:38:33Z

Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a delay to stable the test and multiple run in CI is Ok. Link is added in JBS.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4 (Bug - P4)

Reviewers

Alexey Ivanov (@aivanov-jdk - Reviewer)
Alexander Zvegintsev (@azvegint - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19788/head:pull/19788
$ git checkout pull/19788

Update a local copy of the PR:
$ git checkout pull/19788
$ git pull https://git.openjdk.org/jdk.git pull/19788/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19788

View PR using the GUI difftool:
$ git pr show -t 19788

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19788.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-06-19T08:39:31Z

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-06-19T08:40:41Z

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4

Reviewed-by: aivanov, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

78682fe: 8329288: Update Visual Studio visibility support for POSIX functions
bcf4bb4: 8333344: JMX attaching of Subject does not work when security manager not allowed
856931d: 8304732: jdk/jfr/api/consumer/recordingstream/TestStop.java failed again with "Expected outer stream to have 3 events"
01ee424: 8294960: Convert java.base/java.lang.invoke package to use the Classfile API to generate lambdas and method handles
50bed6c: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager
7b3a96d: 8334488: Improve error for illegal early access from nested class
07ebda5: 8334215: serviceability/dcmd/thread/PrintMountedVirtualThread.java failing with JTREG_TEST_THREAD_FACTORY=Virtual
2165a05: 8334399: [JVMCI] Implement JVMCICompiler::is_intrinsic_supported
48621ae: 8331168: Introduce PredicateEntryIterator to iterate through predicate entries

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-06-19T08:41:09Z

@kumarabhi006 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-06-19T08:44:18Z

Webrevs

00: Full (879fd492)

aivanov-jdk

You should ask Vitaly to test your changeset in his environment to confirm the failure is gone.

aivanov-jdk · 2024-06-19T11:01:26Z

test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java

+        setDelay(50);
        return panel;


How does it help? You're delaying EDT.

You should rather call setDelay(50) to add the delay between method calls.

Alternatively, you can add -delay 50 to the test arguments in its @run tag.

How does it help? You're delaying EDT.

I was unable to reproduce the failure scenario in my local machine but didn't observe any failure in mach5 also. Will ask Vitaly or @azvegint to verify as they are able to replicate the failure.

You should rather call setDelay(50) to add the delay between method calls.

this change does exactly that, it calls SwingTestHelper#setDelay since bug6492108 extends SwingTestHelper

You should ask Vitaly to test your changeset in his environment to confirm the failure is gone.

I am able to reproduce the issue locally on Ubuntu 22.04, and the provided fix works fine for me.

I assume @vprovodin has already done this testing, since he was the one who provided the solution in the JBS issue description.

My bad, I read it as if it were delay(50).

Would it be clearer if setDelay(50) was called in the constructor of bug6492108?

Would it be clearer if setDelay(50) was called in the constructor of bug6492108?

I am ok with the current placing of setDelay(50).

azvegint · 2024-06-19T15:38:10Z

test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java

+        setDelay(50);
        return panel;


You should rather call setDelay(50) to add the delay between method calls.

this change does exactly that, it calls SwingTestHelper#setDelay since bug6492108 extends SwingTestHelper

You should ask Vitaly to test your changeset in his environment to confirm the failure is gone.

I am able to reproduce the issue locally on Ubuntu 22.04, and the provided fix works fine for me.

I assume @vprovodin has already done this testing, since he was the one who provided the solution in the JBS issue description.

aivanov-jdk · 2024-06-19T19:20:24Z

test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java

+        setDelay(50);
        return panel;


My bad, I read it as if it were delay(50).

kumarabhi006 · 2024-06-20T15:41:46Z

/integrate

openjdk · 2024-06-20T15:42:18Z

Going to push as commit 9ef86da.
Since your change was applied there have been 20 commits pushed to the master branch:

001d686: 8332587: RISC-V: secondary_super_cache does not scale well
5cad0b4: 8322708: Global HTML attributes are not allowed
6420846: 8334396: RISC-V: verify perf of ReverseBytesI/L
c6f3bf4: 8334026: Provide a diagnostic PrintMemoryMapAtExit switch on Linux
cabd104: 8334164: The fix for JDK-8322811 should use _filename.is_set() rather than strcmp()
d7dad50: 8334544: C2: wrong control assigned in PhaseIdealLoop::clone_assertion_predicate_for_unswitched_loops()
ff30240: 8334239: Introduce macro for ubsan method/function exclusions
2d4185f: 8332717: ZGC: Division by zero in heuristics
fad6644: 8333754: Add a Test against ECDSA and ECDH NIST Test vector
b211929: 8334570: Problem list gc/TestAlwaysPreTouchBehavior.java
... and 10 more: https://git.openjdk.org/jdk/compare/e227c7e37d4de0656f013f3a936b1acfa56cc2e0...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-06-20T15:42:26Z

@kumarabhi006 Pushed as commit 9ef86da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

delay added for stable test

879fd49

openjdk bot added the rfr Pull request is ready for review label Jun 19, 2024

openjdk bot added the client client-libs-dev@openjdk.org label Jun 19, 2024

aivanov-jdk reviewed Jun 19, 2024

View reviewed changes

azvegint approved these changes Jun 19, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 19, 2024

aivanov-jdk approved these changes Jun 19, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Jun 20, 2024

openjdk bot closed this Jun 20, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 20, 2024

8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4 #19788

8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4 #19788

Uh oh!

Conversation

kumarabhi006 commented Jun 19, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Jun 19, 2024

Uh oh!

openjdk bot commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jun 19, 2024

Uh oh!

mlbridge bot commented Jun 19, 2024

Webrevs

Uh oh!

aivanov-jdk left a comment

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

azvegint Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 Jun 20, 2024

Choose a reason for hiding this comment

Uh oh!

azvegint Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 commented Jun 20, 2024

Uh oh!

openjdk bot commented Jun 20, 2024

Uh oh!

openjdk bot commented Jun 20, 2024

Uh oh!

Uh oh!

kumarabhi006 commented Jun 19, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Jun 19, 2024 •

edited

Loading

azvegint Jun 19, 2024 •

edited

Loading

azvegint Jun 19, 2024 •

edited

Loading