-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8334560: [PPC64]: postalloc_expand_java_dynamic_call_sched does not copy all fields #19789
8334560: [PPC64]: postalloc_expand_java_dynamic_call_sched does not copy all fields #19789
Conversation
👋 Welcome back rrich! A progress list of the required criteria for merging this PR into |
@reinrich This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 57 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
aa16d29
to
ae72907
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing it! I think we should also backport it.
Ok, the new test is a new variant of EARelockingSimpleWithAccessInOtherThread
, but with a dynamic call. LGTM.
Thanks for the reviews! |
Going to push as commit 13dce29.
Your commit was automatically rebased without conflicts. |
On PPC64 we use a special feature where C2 Mach nodes get expanded after register allocation.
This pr adds copying the field
MachSafePointNode::_has_ea_local_in_scope
when expandingMachCallDynamicJavaNode
s inpostalloc_expand_java_dynamic_call_sched
.It adds also a test case that fails without the fix.
The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. Renaissance Suite and SAP specific tests.
Testing was done with fastdebug and release builds on the main platforms and also on Linux/PPC64le and AIX.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19789/head:pull/19789
$ git checkout pull/19789
Update a local copy of the PR:
$ git checkout pull/19789
$ git pull https://git.openjdk.org/jdk.git pull/19789/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19789
View PR using the GUI difftool:
$ git pr show -t 19789
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19789.diff
Webrev
Link to Webrev Comment