8334567: [test] runtime/os/TestTracePageSizes move ppc handling

[MBaesken]

The handling of ppc in runtime/os/TestTracePageSizes should be moved to the test headers.
This is done for x86_64 too in one case, make it more consistent.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8334567: [test] runtime/os/TestTracePageSizes move ppc handling (Bug - P4)

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)
• Lutz Schmidt (@RealLucy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19793/head:pull/19793
$ git checkout pull/19793

Update a local copy of the PR:
$ git checkout pull/19793
$ git pull https://git.openjdk.org/jdk.git pull/19793/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19793

View PR using the GUI difftool:
$ git pr show -t 19793

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19793.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334567: [test] runtime/os/TestTracePageSizes move ppc handling

Reviewed-by: stuefe, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• a81e1bf: 8332252: Clean up vmTestbase/vm/share
• 99e4d77: 8333117: Remove support of remote and manual debuggee launchers
• 9ef86da: 8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4
• 001d686: 8332587: RISC-V: secondary_super_cache does not scale well
• 5cad0b4: 8322708: Global HTML attributes are not allowed
• 6420846: 8334396: RISC-V: verify perf of ReverseBytesI/L
• c6f3bf4: 8334026: Provide a diagnostic PrintMemoryMapAtExit switch on Linux
• cabd104: 8334164: The fix for JDK-8322811 should use _filename.is_set() rather than strcmp()
• d7dad50: 8334544: C2: wrong control assigned in PhaseIdealLoop::clone_assertion_predicate_for_unswitched_loops()
• ff30240: 8334239: Introduce macro for ubsan method/function exclusions
• ... and 8 more: https://git.openjdk.org/jdk/compare/50bed6c67b1edd7736bdf79308d135a4e1047ff0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bd5c0721)

[tstuefe]

Okay.

BTW, what is different about the smaps file on PPC? I would have thought that its format is the same across all linux architectures.

[RealLucy]

Looks good.

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 6a5cb0b.
Since your change was applied there have been 25 commits pushed to the master branch:

• 880e458: 8333819: Move embedded external addresses from relocation info into separate global table
• e5de26d: 8329032: C2 compiler register allocation support for APX EGPRs
• 4b4a483: 8330699: Obsolete -XX:+UseEmptySlotsInSupers
• 187710e: 8333300: [JVMCI] add support for generational ZGC
• de8ee97: 8334333: MissingResourceCauseTestRun.java fails if run by root
• 265a0f5: 8334490: Normalize string with locale invariant toLowerCase()
• 1b1dba8: 8333358: java/io/IO/IO.java test fails intermittently
• a81e1bf: 8332252: Clean up vmTestbase/vm/share
• 99e4d77: 8333117: Remove support of remote and manual debuggee launchers
• 9ef86da: 8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4
• ... and 15 more: https://git.openjdk.org/jdk/compare/50bed6c67b1edd7736bdf79308d135a4e1047ff0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 6a5cb0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.