Skip to content

8334570: Problem list gc/TestAlwaysPreTouchBehavior.java#19794

Closed
SoniaZaldana wants to merge 2 commits intoopenjdk:masterfrom
SoniaZaldana:JDK-8334570
Closed

8334570: Problem list gc/TestAlwaysPreTouchBehavior.java#19794
SoniaZaldana wants to merge 2 commits intoopenjdk:masterfrom
SoniaZaldana:JDK-8334570

Conversation

@SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Jun 19, 2024

Hi all,

This PR addresses 8334570 problem listing gc/TestAlwaysPreTouchBehavior.java until the underlying issues are resolved.

Note that despite failures only showing up for some collectors (G1 on linux-ppc64le, ZSingleGen and the parallel collector on macos-aarch64), I am problem listing all collectors in case it has to do with underprovisioned machines leading to the errors trickling down to the other test cases.

Thanks,
Sonia


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8334570: Problem list gc/TestAlwaysPreTouchBehavior.java (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19794/head:pull/19794
$ git checkout pull/19794

Update a local copy of the PR:
$ git checkout pull/19794
$ git pull https://git.openjdk.org/jdk.git pull/19794/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19794

View PR using the GUI difftool:
$ git pr show -t 19794

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19794.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2024

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334570: Problem list gc/TestAlwaysPreTouchBehavior.java

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 78682fe: 8329288: Update Visual Studio visibility support for POSIX functions
  • bcf4bb4: 8333344: JMX attaching of Subject does not work when security manager not allowed
  • 856931d: 8304732: jdk/jfr/api/consumer/recordingstream/TestStop.java failed again with "Expected outer stream to have 3 events"
  • 01ee424: 8294960: Convert java.base/java.lang.invoke package to use the Classfile API to generate lambdas and method handles

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@albertnetymk, @tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@SoniaZaldana To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@SoniaZaldana
Copy link
Member Author

/label hotspot hotspot-gc

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org labels Jun 19, 2024
@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@SoniaZaldana
The hotspot label was successfully added.

The hotspot-gc label was successfully added.

@SoniaZaldana SoniaZaldana marked this pull request as ready for review June 19, 2024 15:06
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 19, 2024
@tstuefe
Copy link
Member

tstuefe commented Jun 19, 2024

Can you please ignore this for generic-all?

@mlbridge
Copy link

mlbridge bot commented Jun 19, 2024

Webrevs

@SoniaZaldana
Copy link
Member Author

Can you please ignore this for generic-all?

Sure, I updated it.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 19, 2024
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and trivial.

@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 19, 2024
@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@SoniaZaldana
Your change (at version 74ce7dd) is now ready to be sponsored by a Committer.

@dholmes-ora
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 20, 2024

Going to push as commit b211929.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 4e58d8c: 8309821: Link to hidden classes section in Class specification for Class::isHidden
  • 78682fe: 8329288: Update Visual Studio visibility support for POSIX functions
  • bcf4bb4: 8333344: JMX attaching of Subject does not work when security manager not allowed
  • 856931d: 8304732: jdk/jfr/api/consumer/recordingstream/TestStop.java failed again with "Expected outer stream to have 3 events"
  • 01ee424: 8294960: Convert java.base/java.lang.invoke package to use the Classfile API to generate lambdas and method handles

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 20, 2024
@openjdk openjdk bot closed this Jun 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 20, 2024
@openjdk
Copy link

openjdk bot commented Jun 20, 2024

@dholmes-ora @SoniaZaldana Pushed as commit b211929.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

5 participants