Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334315: Shenandoah: reduce GC logging noise #19795

Closed
wants to merge 19 commits into from

Conversation

kdnilsen
Copy link
Contributor

@kdnilsen kdnilsen commented Jun 19, 2024

Qualify certain log messages as ergo or debug to remove extraneous noise from regular gc logs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8334315: Shenandoah: reduce GC logging noise (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19795/head:pull/19795
$ git checkout pull/19795

Update a local copy of the PR:
$ git checkout pull/19795
$ git pull https://git.openjdk.org/jdk.git pull/19795/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19795

View PR using the GUI difftool:
$ git pr show -t 19795

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19795.diff

Webrev

Link to Webrev Comment

@kdnilsen kdnilsen marked this pull request as draft June 19, 2024 15:11
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2024

👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@kdnilsen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334315: Shenandoah: reduce GC logging noise

Reviewed-by: wkemper, ysr, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 467 new commits pushed to the master branch:

  • 4bcb8f0: 8337243: Fix more -Wzero-as-null-pointer-constant warnings in compiler code
  • 3abe8a6: 8336663: [JVMCI] VM Crash on ZGC due to incompatible handle returned by HotSpotJVMCIRuntime#getJObjectValue
  • 5ff7c57: 8337168: Optimize LocalDateTime.toString
  • 374fca0: 8335967: "text-decoration: none" does not work with "A" HTML tags
  • 2aeb12e: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration
  • d10afa2: 8336245: AArch64: remove extra register copy when converting from long to pointer
  • 7f11935: 8337167: StringSize deduplication
  • 487450c: 8216471: GTK LnF: Frame is clipped and does not show JTable,Tooltip and JTree demo in SwingSet2 demo
  • 29f0f17: 8336879: Always true condition 'img != null' in GTKPainter.paintPopupMenuBackground
  • ee839b7: 8337239: Fix simple -Wzero-as-null-pointer-constant warnings in classfile code
  • ... and 457 more: https://git.openjdk.org/jdk/compare/8464ce6db5cbd5d50ac2a2bcba905b7255f510f5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@earthling-amzn, @ysramakrishna, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@kdnilsen The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jun 19, 2024
@kdnilsen kdnilsen marked this pull request as ready for review July 9, 2024 21:16
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 9, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 9, 2024

Webrevs

Copy link
Member

@ysramakrishna ysramakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚢

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 9, 2024
@shipilev
Copy link
Member

Any reason we are not integrating this? Still noise in GC logs :)

@kdnilsen
Copy link
Contributor Author

/integrate

@shipilev
Copy link
Member

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 26, 2024
@openjdk
Copy link

openjdk bot commented Jul 26, 2024

@kdnilsen
Your change (at version 2a74ecc) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Jul 26, 2024

Going to push as commit f35af71.
Since your change was applied there have been 467 commits pushed to the master branch:

  • 4bcb8f0: 8337243: Fix more -Wzero-as-null-pointer-constant warnings in compiler code
  • 3abe8a6: 8336663: [JVMCI] VM Crash on ZGC due to incompatible handle returned by HotSpotJVMCIRuntime#getJObjectValue
  • 5ff7c57: 8337168: Optimize LocalDateTime.toString
  • 374fca0: 8335967: "text-decoration: none" does not work with "A" HTML tags
  • 2aeb12e: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration
  • d10afa2: 8336245: AArch64: remove extra register copy when converting from long to pointer
  • 7f11935: 8337167: StringSize deduplication
  • 487450c: 8216471: GTK LnF: Frame is clipped and does not show JTable,Tooltip and JTree demo in SwingSet2 demo
  • 29f0f17: 8336879: Always true condition 'img != null' in GTKPainter.paintPopupMenuBackground
  • ee839b7: 8337239: Fix simple -Wzero-as-null-pointer-constant warnings in classfile code
  • ... and 457 more: https://git.openjdk.org/jdk/compare/8464ce6db5cbd5d50ac2a2bcba905b7255f510f5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 26, 2024
@openjdk openjdk bot closed this Jul 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 26, 2024
@openjdk
Copy link

openjdk bot commented Jul 26, 2024

@shipilev @kdnilsen Pushed as commit f35af71.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants