8334653: ISO 4217 Amendment 177 Update #19813

justin-curtis-lu · 2024-06-20T18:01:39Z

Please review this PR which incorporates the ISO 4217 Amendment 177 Update.

Specifically, the introduction of the new currency, Zimbabwe Gold.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8334653: ISO 4217 Amendment 177 Update (Bug - P3)

Reviewers

Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19813/head:pull/19813
$ git checkout pull/19813

Update a local copy of the PR:
$ git checkout pull/19813
$ git pull https://git.openjdk.org/jdk.git pull/19813/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19813

View PR using the GUI difftool:
$ git pr show -t 19813

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19813.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-06-20T18:02:21Z

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-06-20T18:03:20Z

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334653: ISO 4217 Amendment 177 Update

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

a4582a8: 8334166: Enable binary check
7baddc2: 8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3
eb110bd: 8334180: NMT gtests introduced with 8312132 should be labeled as NMT
652784c: 8334392: Switch RNG in NMT's treap
72ca7ba: 8334708: FFM: two javadoc problems
7e55ed3: 8333748: javap crash - Fatal error: Unmatched bit position 0x2 for location CLASS
1ff5acd: 8332099: since-checker - Add @ since to package-info in jdk.jsobject
689cee3: 8334509: Cancelling PageDialog does not return the same PageFormat object
8e1d2b0: 8334441: Mark tests in jdk_security_infra group as manual
93d9802: 8334715: [riscv] Mixed use of tab and whitespace in riscv.ad
... and 16 more: https://git.openjdk.org/jdk/compare/1b1dba8082969244effa86ac03c6053b3b0ddc43...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-06-20T18:03:55Z

@justin-curtis-lu The following labels will be automatically applied to this pull request:

core-libs
i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-06-20T18:06:35Z

Webrevs

naotoj · 2024-06-20T18:16:37Z

src/java.base/share/data/currency/CurrencyData.properties

@@ -582,7 +582,7 @@ YE=YER
 # ZAMBIA
 ZM=ZMW
 # ZIMBABWE
-ZW=ZWL
+ZW=ZWL;2024-08-31-22-00-00;ZWG


JDK switches the currency at the beginning of the transition period. So in this case, it's 6/25. So we don't need to even specify the transition at all, as the next build drop is beyond that date.

Good to know. Removed the cutover dates.

naotoj · 2024-06-20T18:16:47Z

test/jdk/java/util/Currency/tablea1.txt

@@ -276,7 +276,7 @@ WF	XPF	953	0
 EH	MAD	504	2
 YE	YER	886	2
 ZM	ZMW	967	2
-ZW	ZWL	932	2
+ZW	ZWL	932	2	2024-08-31-22-00-00	ZWG	924	2


Same as above

naotoj · 2024-06-20T18:21:41Z

src/java.base/share/classes/sun/util/resources/CurrencyNames.properties

@@ -512,5 +513,6 @@ yum=Yugoslavian New Dinar (1994-2002)
 zar=South African Rand
 zmk=Zambian Kwacha
 zwd=Zimbabwean Dollar (1980-2008)
+zwg=Zimbabwe Gold


It's interesting to see the difference Zimbabwe and Zimbabwean here. The latter is from CLDR and the name for ZWG is not yet available, so we may need to pull the name from CLDR later.

I see your point. CLDR takes precedence over ISO4217 regarding currencies here?

That is more consistent IMO

CLDR is aware of this change but hasn't added it yet. We're mid cycle so it won't be much more than metadata this round due to timing. https://unicode-org.atlassian.net/issues/CLDR-17751 if you want to track.

CLDR is aware of this change but hasn't added it yet. We're mid cycle so it won't be much more than metadata this round due to timing. https://unicode-org.atlassian.net/issues/CLDR-17751 if you want to track.

Out of curiosity, what's the rationale behind the currency name change from "Zimbabwe Dollar" (ISO 4217 definition) to "Zimbabwean Dollar"?

Out of curiosity, what's the rationale behind the currency name change from "Zimbabwe Dollar" (ISO 4217 definition) to "Zimbabwean Dollar"?

I'm not sure.

naotoj · 2024-06-20T18:36:22Z

It's not about this update, but it may be better to rename the tablea1.txt data file to list-one.txt or something along the line. The name tablea1 is obsolete, and it is now called "List one: Currency, fund and precious metal codes"
https://www.six-group.com/en/products-services/financial-information/data-standards.html

justin-curtis-lu · 2024-06-20T19:01:29Z

It's not about this update, but it may be better to rename the tablea1.txt data file to list-one.txt or something along the line. The name tablea1 is obsolete, and it is now called "List one: Currency, fund and precious metal codes" https://www.six-group.com/en/products-services/financial-information/data-standards.html

Without further context, it is hard to infer meaning from tablea1.txt or list-one.txt. I have renamed it to ISO4217-codes.txt, which I think is much more straight forward and provides immediate info.

naotoj · 2024-06-20T19:51:51Z

It's not about this update, but it may be better to rename the tablea1.txt data file to list-one.txt or something along the line. The name tablea1 is obsolete, and it is now called "List one: Currency, fund and precious metal codes" https://www.six-group.com/en/products-services/financial-information/data-standards.html

Without further context, it is hard to infer meaning from tablea1.txt or list-one.txt. I have renamed it to ISO4217-codes.txt, which I think is much more straight forward and provides immediate info.

The point I wanted to make is that the text file only contains the "list one" part of the ISO 4217. Looks like "list two" is a subset of list one (as they are funds codes), but "list three", which lists historic codes, is definitely not covered in that file.

I am ok with the suggested name, but then we should include some comments mentioning this.

justin-curtis-lu · 2024-06-20T20:09:31Z

The point I wanted to make is that the text file only contains the "list one" part of the ISO 4217.

Renamed the file name to "ISO4217-list-one.txt"

justin-curtis-lu · 2024-06-25T19:03:27Z

/integrate

openjdk · 2024-06-25T19:05:24Z

Going to push as commit 86b0cf2.
Since your change was applied there have been 54 commits pushed to the master branch:

861aefc: 8334418: Update IANA Language Subtag Registry to Version 2024-06-14
f8bf470: 8334810: Redo: Un-ProblemList LocaleProvidersRun and CalendarDataRegression
933eaba: 8334629: [BACKOUT] PhaseIdealLoop::conditional_move is too conservative
7429c37: 8334598: Default classlist in JDK is not deterministic after JDK-8293980
9c89f08: 8334421: assert(!oldbox->is_unbalanced()) failed: this should not be called for unbalanced region
57f8b91: 8333658: NMT: Use an allocator with 4-byte pointers to save memory in NativeCallStackStorage
6c67933: 8334899: Test runtime/cds/appcds/javaldr/ExceptionDuringDumpAtObjectsInitPhase.java failed after JDK-8306580
cae94b2: 8334397: RISC-V: verify perf of ReverseBytesS/US
75a2afa: 8248981: Specify list of standard message digest and mgf algorithms for RSASSA-PSS signature
baafa66: 8334287: Man page update for jstatd deprecation
... and 44 more: https://git.openjdk.org/jdk/compare/1b1dba8082969244effa86ac03c6053b3b0ddc43...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-06-25T19:05:31Z

@justin-curtis-lu Pushed as commit 86b0cf2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk · 2024-07-01T13:30:57Z

@weibxiao The target repository jdk23u-cpu-open is not a valid target for backports.
List of valid target repositories: openjdk/jdk, openjdk/jdk11u, openjdk/jdk11u-dev, openjdk/jdk17u, openjdk/jdk17u-dev, openjdk/jdk21u, openjdk/jdk21u-dev, openjdk/jdk22u, openjdk/jdk23u, openjdk/jdk7u, openjdk/jdk8u, openjdk/jdk8u-dev, openjdk/jfx, openjdk/jfx17u, openjdk/jfx21u, openjdk/jfx22u, openjdk/lilliput-jdk17u, openjdk/lilliput-jdk21u, openjdk/shenandoah-jdk21u, openjdk/shenandoah-jdk8u.
Supplying the organization/group prefix is optional.

weibxiao · 2024-07-01T13:37:51Z

/backport openjdk/jdk23u

openjdk · 2024-07-01T13:39:45Z

@weibxiao the backport was successfully created on the branch backport-weibxiao-86b0cf25-master in my personal fork of openjdk/jdk23u. To create a pull request with this backport targeting openjdk/jdk23u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 86b0cf25 from the openjdk/jdk repository.

The commit being backported was authored by Justin Lu on 25 Jun 2024 and was reviewed by Naoto Sato.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk23u:

$ git fetch https://github.com/openjdk-bots/jdk23u.git backport-weibxiao-86b0cf25-master:backport-weibxiao-86b0cf25-master
$ git checkout backport-weibxiao-86b0cf25-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk23u.git backport-weibxiao-86b0cf25-master

⚠️ @weibxiao You are not yet a collaborator in my fork openjdk-bots/jdk23u. An invite will be sent out and you need to accept it before you can proceed.

justin-curtis-lu · 2024-07-10T22:06:09Z

/backport :jdk23

openjdk · 2024-07-10T22:07:09Z

@justin-curtis-lu the backport was successfully created on the branch backport-justin-curtis-lu-86b0cf25-jdk23 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk23, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 86b0cf25 from the openjdk/jdk repository.

The commit being backported was authored by Justin Lu on 25 Jun 2024 and was reviewed by Naoto Sato.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-justin-curtis-lu-86b0cf25-jdk23:backport-justin-curtis-lu-86b0cf25-jdk23
$ git checkout backport-justin-curtis-lu-86b0cf25-jdk23
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-justin-curtis-lu-86b0cf25-jdk23

init

37d1bed

openjdk bot changed the title ~~JDK-8334653: ISO 4217 Amendment 177 Update~~ 8334653: ISO 4217 Amendment 177 Update Jun 20, 2024

openjdk bot added the rfr Pull request is ready for review label Jun 20, 2024

openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jun 20, 2024

naotoj reviewed Jun 20, 2024

View reviewed changes

reflect review comments

761d8ef

reflect review: change txt name

58c0900

naotoj approved these changes Jun 21, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 21, 2024

openjdk bot added the integrated Pull request has been integrated label Jun 25, 2024

openjdk bot closed this Jun 25, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8334653: ISO 4217 Amendment 177 Update #19813

8334653: ISO 4217 Amendment 177 Update #19813

justin-curtis-lu commented Jun 20, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jun 20, 2024

openjdk bot commented Jun 20, 2024 •

edited

Loading

openjdk bot commented Jun 20, 2024

mlbridge bot commented Jun 20, 2024 •

edited

Loading

naotoj Jun 20, 2024

justin-curtis-lu Jun 20, 2024

naotoj Jun 20, 2024

naotoj Jun 20, 2024

justin-curtis-lu Jun 20, 2024

naotoj Jun 20, 2024

srl295 Jun 20, 2024

naotoj Jun 21, 2024

srl295 Jul 10, 2024

naotoj commented Jun 20, 2024

justin-curtis-lu commented Jun 20, 2024

naotoj commented Jun 20, 2024

justin-curtis-lu commented Jun 20, 2024

justin-curtis-lu commented Jun 25, 2024

openjdk bot commented Jun 25, 2024

openjdk bot commented Jun 25, 2024

openjdk bot commented Jul 1, 2024

weibxiao commented Jul 1, 2024

openjdk bot commented Jul 1, 2024

justin-curtis-lu commented Jul 10, 2024

openjdk bot commented Jul 10, 2024

8334653: ISO 4217 Amendment 177 Update #19813

8334653: ISO 4217 Amendment 177 Update #19813

Conversation

justin-curtis-lu commented Jun 20, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Jun 20, 2024

openjdk bot commented Jun 20, 2024 • edited Loading

openjdk bot commented Jun 20, 2024

mlbridge bot commented Jun 20, 2024 • edited Loading

Webrevs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naotoj commented Jun 20, 2024

justin-curtis-lu commented Jun 20, 2024

naotoj commented Jun 20, 2024

justin-curtis-lu commented Jun 20, 2024

justin-curtis-lu commented Jun 25, 2024

openjdk bot commented Jun 25, 2024

openjdk bot commented Jun 25, 2024

openjdk bot commented Jul 1, 2024

weibxiao commented Jul 1, 2024

openjdk bot commented Jul 1, 2024

justin-curtis-lu commented Jul 10, 2024

openjdk bot commented Jul 10, 2024

justin-curtis-lu commented Jun 20, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Jun 20, 2024 •

edited

Loading

mlbridge bot commented Jun 20, 2024 •

edited

Loading