8334441: Mark tests in jdk_security_infra group as manual

[rhalade]

Updated all the tests that depend on external infrastructure services as manual. These tests may fail with external reasons, for instance - change in CA test portal, certificate status updates, or network issues.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8334441: Mark tests in jdk_security_infra group as manual (Bug - P3)

Reviewers

• Christoph Langer (@RealCLanger - Reviewer) ⚠️ Review applies to 5f1889af
• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19814/head:pull/19814
$ git checkout pull/19814

Update a local copy of the PR:
$ git checkout pull/19814
$ git pull https://git.openjdk.org/jdk.git pull/19814/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19814

View PR using the GUI difftool:
$ git pr show -t 19814

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19814.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334441: Mark tests in jdk_security_infra group as manual

Reviewed-by: clanger, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• 93d9802: 8334715: [riscv] Mixed use of tab and whitespace in riscv.ad
• c41293a: 8334695: Fix build failure without zgc after JDK-8333300
• 75bea28: 8333867: SHA3 performance can be improved
• 9f8de22: 8327793: Deprecate jstatd for removal
• dbf5a9a: 8334706: [JVMCI] APX registers incorrectly exposed on AMD64
• 08ace27: 8332314: Add window size configuration option to JavaShellToolBuilder interface
• 711e723: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser
• d2bebff: 8327370: (ch) sun.nio.ch.Poller.register throws AssertionError
• ed14906: 8333361: ubsan,test : libHeapMonitorTest.cpp:518:9: runtime error: null pointer passed as argument 2, which is declared to never be null
• bdd9660: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"
• ... and 33 more: https://git.openjdk.org/jdk/compare/e965d70a7425bec78620a2ca8bfaca3c392edf6a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@rhalade The following labels will be automatically applied to this pull request:

• core-libs
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (2fdaa890)
• 00: Full (5f1889af)

[RealCLanger]

Looks good, although I don't see why sometimes the directive is @run main/othervm/manual/manual (double occurence of manual).

[rhalade]

/integrate

[openjdk]

Going to push as commit 8e1d2b0.
Since your change was applied there have been 43 commits pushed to the master branch:

• 93d9802: 8334715: [riscv] Mixed use of tab and whitespace in riscv.ad
• c41293a: 8334695: Fix build failure without zgc after JDK-8333300
• 75bea28: 8333867: SHA3 performance can be improved
• 9f8de22: 8327793: Deprecate jstatd for removal
• dbf5a9a: 8334706: [JVMCI] APX registers incorrectly exposed on AMD64
• 08ace27: 8332314: Add window size configuration option to JavaShellToolBuilder interface
• 711e723: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser
• d2bebff: 8327370: (ch) sun.nio.ch.Poller.register throws AssertionError
• ed14906: 8333361: ubsan,test : libHeapMonitorTest.cpp:518:9: runtime error: null pointer passed as argument 2, which is declared to never be null
• bdd9660: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"
• ... and 33 more: https://git.openjdk.org/jdk/compare/e965d70a7425bec78620a2ca8bfaca3c392edf6a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rhalade Pushed as commit 8e1d2b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[gnu-andrew]

Is there still going to be some monitoring of these tests? Making it harder to run these tests potentially means that genuine failures can go unnoticed and JDK certificates are not updated when needed.

[rhalade]

Is there still going to be some monitoring of these tests? Making it harder to run these tests potentially means that genuine failures can go unnoticed and JDK certificates are not updated when needed.

Tracking won’t be any different than other manual tests in the test suite. Within Oracle, we recommend that developers working on security libraries fixes run these tests before integration. All manual tests are definitely run during the release certification.