Skip to content

Conversation

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Jun 21, 2024

Hi all,

The patch fixes the build failure without zgc.
Please review.

Thanks.
Best regards,
Jie


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8334695: Fix build failure without zgc after JDK-8333300 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19818/head:pull/19818
$ git checkout pull/19818

Update a local copy of the PR:
$ git checkout pull/19818
$ git pull https://git.openjdk.org/jdk.git pull/19818/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19818

View PR using the GUI difftool:
$ git pr show -t 19818

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19818.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2024

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 21, 2024

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334695: Fix build failure without zgc after JDK-8333300

Reviewed-by: dnsimon, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 08ace27: 8332314: Add window size configuration option to JavaShellToolBuilder interface
  • 711e723: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser
  • d2bebff: 8327370: (ch) sun.nio.ch.Poller.register throws AssertionError
  • ed14906: 8333361: ubsan,test : libHeapMonitorTest.cpp:518:9: runtime error: null pointer passed as argument 2, which is declared to never be null
  • bdd9660: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"
  • 6a5cb0b: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 21, 2024
@openjdk
Copy link

openjdk bot commented Jun 21, 2024

@DamonFool The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Jun 21, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 21, 2024
@dougxc
Copy link
Member

dougxc commented Jun 21, 2024

I assume --with-jvm-features=-zgc is never tested by mach5 or GitHub actions.

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, too.

@DamonFool
Copy link
Member Author

Thanks @dougxc and @chhagedorn for the review.

Will push it later since it's a build broken.

@DamonFool
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 21, 2024

Going to push as commit c41293a.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 75bea28: 8333867: SHA3 performance can be improved
  • 9f8de22: 8327793: Deprecate jstatd for removal
  • dbf5a9a: 8334706: [JVMCI] APX registers incorrectly exposed on AMD64
  • 08ace27: 8332314: Add window size configuration option to JavaShellToolBuilder interface
  • 711e723: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser
  • d2bebff: 8327370: (ch) sun.nio.ch.Poller.register throws AssertionError
  • ed14906: 8333361: ubsan,test : libHeapMonitorTest.cpp:518:9: runtime error: null pointer passed as argument 2, which is declared to never be null
  • bdd9660: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"
  • 6a5cb0b: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 21, 2024
@openjdk openjdk bot closed this Jun 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 21, 2024
@openjdk
Copy link

openjdk bot commented Jun 21, 2024

@DamonFool Pushed as commit c41293a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8334695 branch June 21, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants