8259373: c1 and jvmci runtime code use ResetNoHandleMark incorrectly

[coleenp]

Please review this trivial change to the compiler runtime code. See CR for details. Tested with tier1-3.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259373: c1 and jvmci runtime code use ResetNoHandleMark incorrectly

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1982/head:pull/1982
$ git checkout pull/1982

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fa33a7e)

[vnkozlov]

Good.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259373: c1 and jvmci runtime code use ResetNoHandleMark incorrectly

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• d8ad630: 8258772: Some runtime/cds tests fail with +LogCompilation or +StressX
• 4ce83f2: 8039278: console.sh failed Automatically with exit code 1
• 2e99e28: 8213126: java/awt/Window/MainKeyWindow/TestMainKeyWindow.java time-out on mac10.13
• 8530ef0: 8259375: JvmtiExport::jni_Get/SetField_probe calls do not need ResetNoHandleMark
• f91f92d: 8259317: Remove JVM option BreakAtWarning
• 3f9f86f: 8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006
• 1c33847: 8259067: bootclasspath append takes out object lock
• 0e6de4e: 8259339: AllocateUninitializedArray C2 intrinsic fails with void.class input
• 81c0624: 8259354: Fix race condition in AbstractEventStream.nextThreadName
• 227f99d: 8233555: [TESTBUG] JRadioButton tests failing on MacoS
• ... and 2 more: https://git.openjdk.java.net/jdk/compare/80544e4d5f402f67171eb5aca11897f1c5c3d431...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Thanks Vladimir. Trivial too?

[vnkozlov]

Thanks Vladimir. Trivial too?

Yes, trivial. What testing you did?

[coleenp]

I ran tier1-3 testing on it. Does that test jvmciRuntime ? I thought it did.

[vnkozlov]

Yes, JVMCI is tested in tier1.
Changes are good for push.

[coleenp]

Thanks Vladimir!
/integrate

[openjdk]

@coleenp Since your change was applied there have been 32 commits pushed to the master branch:

• 555641e: Merge
• 4f914e2: 8249633: doclint reports missing javadoc for JavaFX property methods that have a property description
• eef43be: 8251200: False positive messages about missing comments for serialization
• f1bc4e0: 8259312: VerifyCACerts.java fails as soneraclass2ca cert will expire in 90 days
• 4a5786b: 8259075: Update the copyright notice in the files generated by CLDR Converter tool
• d25a1be: 8259224: (ann) getAnnotatedReceiverType should not parameterize owner(s) of statically nested classes
• ad45678: 8258558: Revert changes for JDK-8252505 and related issues
• e66187d: 8259032: MappedMemorySegmentImpl#makeMappedSegment() ignores Unmapper#pagePosition
• 80110da: 8259007: This test printed a blank page
• 554e60c: 8258989: JVM is failed to inline in jdk.internal.vm.vector.VectorSupport::convert
• ... and 22 more: https://git.openjdk.java.net/jdk/compare/80544e4d5f402f67171eb5aca11897f1c5c3d431...master

Your commit was automatically rebased without conflicts.

Pushed as commit b996ccc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.