Skip to content

8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" #19822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Jun 21, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19822/head:pull/19822
$ git checkout pull/19822

Update a local copy of the PR:
$ git checkout pull/19822
$ git pull https://git.openjdk.org/jdk.git pull/19822/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19822

View PR using the GUI difftool:
$ git pr show -t 19822

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19822.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2024

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 21, 2024

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the jdk23 branch:

  • a124e6e: 8333748: javap crash - Fatal error: Unmatched bit position 0x2 for location CLASS
  • 0779f0d: 8334762: [BACKOUT BACKPORT] Improve error for illegal early access from nested class
  • bd66b6b: 8333358: java/io/IO/IO.java test fails intermittently
  • 3edf379: 8334708: FFM: two javadoc problems
  • 10d81a3: 8334441: Mark tests in jdk_security_infra group as manual
  • 1dbad80: 8333854: IllegalAccessError with proxies after JDK-8332457
  • 2151493: 8334333: MissingResourceCauseTestRun.java fails if run by root
  • 23f2c97: 8333344: JMX attaching of Subject does not work when security manager not allowed

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk23 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport bdd96604ae55ba0cd3cd3363e2ba44205d8aa3aa 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" Jun 21, 2024
@openjdk
Copy link

openjdk bot commented Jun 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 21, 2024

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jun 21, 2024
@egahlin egahlin marked this pull request as ready for review June 21, 2024 08:27
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 21, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 24, 2024
@egahlin
Copy link
Member Author

egahlin commented Jun 24, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

Going to push as commit fa7521b.
Since your change was applied there have been 9 commits pushed to the jdk23 branch:

  • fbcf6d9: 8334509: Cancelling PageDialog does not return the same PageFormat object
  • a124e6e: 8333748: javap crash - Fatal error: Unmatched bit position 0x2 for location CLASS
  • 0779f0d: 8334762: [BACKOUT BACKPORT] Improve error for illegal early access from nested class
  • bd66b6b: 8333358: java/io/IO/IO.java test fails intermittently
  • 3edf379: 8334708: FFM: two javadoc problems
  • 10d81a3: 8334441: Mark tests in jdk_security_infra group as manual
  • 1dbad80: 8333854: IllegalAccessError with proxies after JDK-8332457
  • 2151493: 8334333: MissingResourceCauseTestRun.java fails if run by root
  • 23f2c97: 8333344: JMX attaching of Subject does not work when security manager not allowed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 24, 2024
@openjdk openjdk bot closed this Jun 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 24, 2024
@openjdk
Copy link

openjdk bot commented Jun 24, 2024

@egahlin Pushed as commit fa7521b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants