8334706: [JVMCI] APX registers incorrectly exposed on AMD64

[dougxc]

This PR fixes a bug introduced by JDK-8329032 which added the APX registers to AMD64.java.
It broke this invariant:

    /**
     * List of all available registers on this architecture. The index of each register in this list
     * is equal to its {@linkplain Register#number number}.
     */
    private final RegisterArray registers;

That invariant is relied upon by the Graal register allocator.
This PR now tests the invariant and fixes the definitions in AMD64.java that were violating it.

This fix was developed by @tkrodriguez.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8334706: [JVMCI] APX registers incorrectly exposed on AMD64 (Bug - P2)

Reviewers

• Yudi Zheng (@mur47x111 - Committer) ⚠️ Review applies to f8028db1
• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19824/head:pull/19824
$ git checkout pull/19824

Update a local copy of the PR:
$ git checkout pull/19824
$ git pull https://git.openjdk.org/jdk.git pull/19824/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19824

View PR using the GUI difftool:
$ git pr show -t 19824

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19824.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334706: [JVMCI] APX registers incorrectly exposed on AMD64

Reviewed-by: yzheng, never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 08ace27: 8332314: Add window size configuration option to JavaShellToolBuilder interface
• 711e723: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (b2851a82)
• 00: Full (f8028db1)

[eme64]

@jatin-bhateja authored the changes in #19042 that causes your issues, and @vnkozlov reviewed it. Maybe they can have a look at this?

[jatin-bhateja]

Hi @dougxc , Thanks for fixing this, a comment over cpuRegisters definition relating to its usage will be helpful.

[dougxc]

I added a brief comment. I will leave it for JDK-8334717 to expand upon this.

[dougxc]

Thanks for the review.

/integrate

[openjdk]

@dougxc This pull request has not yet been marked as ready for integration.

[tkrodriguez]

Looks good. We should clean AMD64.java up a bit in a follow on PR. It should be more obvious how to make these kinds of changes without touching a bunch of arrays.

[dougxc]

/integrate

[openjdk]

Going to push as commit dbf5a9a.
Since your change was applied there have been 2 commits pushed to the master branch:

• 08ace27: 8332314: Add window size configuration option to JavaShellToolBuilder interface
• 711e723: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit dbf5a9a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.