Skip to content

8334706: [JVMCI] APX registers incorrectly exposed on AMD64 #19824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

8334706: [JVMCI] APX registers incorrectly exposed on AMD64 #19824

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8028db
APX registers incorrectly exposed on AMD64
dougxc Jun 21, 2024
b2851a8
added comment to AMD64.cpuRegisters
dougxc Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/amd64/AMD64.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public class AMD64 extends Architecture {
public static final Register r30 = new Register(30, 30, "r30", CPU);
public static final Register r31 = new Register(31, 31, "r31", CPU);

// The set of common CPU registers available on all x64 platforms.
public static final Register[] cpuRegisters = {
rax, rcx, rdx, rbx, rsp, rbp, rsi, rdi,
r8, r9, r10, r11, r12, r13, r14, r15
Copy link
Member

@jatin-bhateja jatin-bhateja Jun 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dougxc , Thanks for fixing this, a comment over cpuRegisters definition relating to its usage will be helpful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a brief comment. I will leave it for JDK-8334717 to expand upon this.

Expand Down