8334299: Deprecate LockingMode option, along with LM_LEGACY and LM_MONITOR

[coleenp]

Add LockingMode to the list of deprecated options and add deprecated message for it.
Tested with tier1-4.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8334496 to be approved

Issues

• JDK-8334299: Deprecate LockingMode option, along with LM_LEGACY and LM_MONITOR (Enhancement - P4)
• JDK-8334496: Deprecate LockingMode option, along with LM_LEGACY and LM_MONITOR (CSR)

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19827/head:pull/19827
$ git checkout pull/19827

Update a local copy of the PR:
$ git checkout pull/19827
$ git pull https://git.openjdk.org/jdk.git pull/19827/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19827

View PR using the GUI difftool:
$ git pr show -t 19827

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19827.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334299: Deprecate LockingMode option, along with LM_LEGACY and LM_MONITOR

Reviewed-by: stuefe, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• a4582a8: 8334166: Enable binary check
• 7baddc2: 8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3
• eb110bd: 8334180: NMT gtests introduced with 8312132 should be labeled as NMT
• 652784c: 8334392: Switch RNG in NMT's treap
• 72ca7ba: 8334708: FFM: two javadoc problems
• 7e55ed3: 8333748: javap crash - Fatal error: Unmatched bit position 0x2 for location CLASS
• 1ff5acd: 8332099: since-checker - Add @ since to package-info in jdk.jsobject
• 689cee3: 8334509: Cancelling PageDialog does not return the same PageFormat object
• 8e1d2b0: 8334441: Mark tests in jdk_security_infra group as manual
• 93d9802: 8334715: [riscv] Mixed use of tab and whitespace in riscv.ad
• ... and 12 more: https://git.openjdk.org/jdk/compare/4b4a483b6fe7a6fcfdfe6f68faac29099a64c982...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (60d1f03c)

[tstuefe]

LGTM

[dholmes-ora]

LGTM2

Thanks

[coleenp]

Thank you Thomas and David.
/integrate

[openjdk]

Going to push as commit 5ac2149.
Since your change was applied there have been 30 commits pushed to the master branch:

• 2e64d15: 8334564: VM startup: fatal error: FLAG_SET_ERGO cannot be used to set an invalid value for NonNMethodCodeHeapSize
• 9d4a4bd: 8324841: PKCS11 tests still skip execution
• ca5a438: 8334571: Extract control dependency rewiring out of PhaseIdealLoop::dominated_by() into separate method
• 05ff318: 8334594: Generational ZGC: Deadlock after OopMap rewrites in 8331572
• 05a63d8: 8334489: Add function os::used_memory
• edf7f05: 8334083: C2 SuperWord: TestCompatibleUseDefTypeSize.java fails with -XX:+AlignVector after JDK-8325155
• 13dce29: 8334560: [PPC64]: postalloc_expand_java_dynamic_call_sched does not copy all fields
• 863b2a9: 8329994: Zap alignment padding bits for ArrayOops in non-release builds
• a4582a8: 8334166: Enable binary check
• 7baddc2: 8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3
• ... and 20 more: https://git.openjdk.org/jdk/compare/4b4a483b6fe7a6fcfdfe6f68faac29099a64c982...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 5ac2149.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.