8259385: Cleanup unused assignment

[XueleiFan]

In the SunJSSE provider implementation, there are a few cases that the assigned value is never used. For example:

  int i = 0;
  i = Byte.toUnsignedInt(buf.get());

could be simplified as
int i = Byte.toUnsignedInt(buf.get());

Code cleanup, no new regression test.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259385: Cleanup unused assignment

Reviewers

• Attila Szegedi (@szegedi - Reviewer) ⚠️ Review applies to 9a31381

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1984/head:pull/1984
$ git checkout pull/1984

[bridgekeeper]

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@XueleiFan The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3ba6e4d)
• 00: Full (9a31381)

[szegedi]

LGTM. Looks like a good ol' IntelliJ IDEA driven fixing (nothing wrong with that.) Maybe you could also fix those "temproary" typos while in there? FWIW, 2 of 3 occurrences of code containing them are almost entirely equivalent and could be refactored into a static method with a Supplier<byte[]> that produces the digest, but I guess it'd be worth filing a separate issue for that.

[openjdk]

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259385: Cleanup unused assignment

Reviewed-by: attila

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

• e7c1740: 8258187: IllegalMonitorStateException in ArrayBlockingQueue
• 11d5b04: 8258217: PriorityBlockingQueue constructor spec and behavior mismatch
• 65ca5c6: 8048109: JToggleButton does not fire actionPerformed under certain conditions
• 81db63e: 8259517: Incorrect test path in test cases
• 270014a: 8234131: Miscellaneous changes imported from jsr166 CVS 2021-01
• 63e3bd7: 8246677: LinkedTransferQueue and SynchronousQueue synchronization updates
• 5cfa8c9: 8246585: ForkJoin updates
• 6472104: 6278172: TextComponent.getSelectedText() throws StringIndexOutOfBoundsException
• a653928: 8259512: Update --release 16 symbol information for JDK 16 build 31
• 7e6677b: 8259446: runtime/jni/checked/TestCheckedReleaseArrayElements.java fails with stderr not empty
• ... and 40 more: https://git.openjdk.java.net/jdk/compare/8530ef0e4dda328d5b9856b03e29b764d06229fb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[XueleiFan]

LGTM. Looks like a good ol' IntelliJ IDEA driven fixing (nothing wrong with that.)

Right.

Maybe you could also fix those "temproary" typos while in there?

Updated. Thanks!

FWIW, 2 of 3 occurrences of code containing them are almost entirely equivalent and could be refactored into a static method with a Supplier<byte[]> that produces the digest, but I guess it'd be worth filing a separate issue for that.

I will make more evaluation if a new issue could be filed.

[XueleiFan]

/integrate

[openjdk]

@XueleiFan Since your change was applied there have been 51 commits pushed to the master branch:

• 9154f64: 8254973: CompletableFuture.ThreadPerTaskExecutor does not throw NPE in #execute
• e7c1740: 8258187: IllegalMonitorStateException in ArrayBlockingQueue
• 11d5b04: 8258217: PriorityBlockingQueue constructor spec and behavior mismatch
• 65ca5c6: 8048109: JToggleButton does not fire actionPerformed under certain conditions
• 81db63e: 8259517: Incorrect test path in test cases
• 270014a: 8234131: Miscellaneous changes imported from jsr166 CVS 2021-01
• 63e3bd7: 8246677: LinkedTransferQueue and SynchronousQueue synchronization updates
• 5cfa8c9: 8246585: ForkJoin updates
• 6472104: 6278172: TextComponent.getSelectedText() throws StringIndexOutOfBoundsException
• a653928: 8259512: Update --release 16 symbol information for JDK 16 build 31
• ... and 41 more: https://git.openjdk.java.net/jdk/compare/8530ef0e4dda328d5b9856b03e29b764d06229fb...master

Your commit was automatically rebased without conflicts.

Pushed as commit b72de3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.