8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature

[mpdonova]

In this PR, I updated the version of NSS to 3.101 and removed the test from the ProblemList for all platforms but linux-ppc64le (that bug is still outstanding.)

I also updated the skipTest logic in TestDSAKeyLength.java. Prior to my change, it compared the version numbers as double values but that doesn't work when version 3.101 is later (i.e., greater) than 3.14.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature (Bug - P3)

Reviewers

• Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19855/head:pull/19855
$ git checkout pull/19855

Update a local copy of the PR:
$ git checkout pull/19855
$ git pull https://git.openjdk.org/jdk.git pull/19855/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19855

View PR using the GUI difftool:
$ git pr show -t 19855

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19855.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdonovan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mpdonova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 447 new commits pushed to the master branch:

• 8af2ef3: 8331015: Obsolete -XX:+UseNotificationThread
• 97f7c03: 8336495: Remove unnecessary casts in output.cpp
• a45bb55: 8337501: JFR: Use TimespanUnit
• 8f039b5: 8336919: Cleanup and rename tags in placeholders code
• e4c7850: 8337027: Parallel: Obsolete BaseFootPrintEstimate
• fdb4350: 8324345: Stack overflow during C2 compilation when splitting memory phi
• f2ba2eb: 8331090: Run Ideal_minmax before de-canonicalizing CMoves
• 7121d71: 8337421: RISC-V: client VM build failure after JDK-8335191
• 61386c1: 8337523: Fix -Wzero-as-null-pointer-constant warnings in jvmci code
• 07dd725: 8337418: Fix -Wzero-as-null-pointer-constant warnings in prims code
• ... and 437 more: https://git.openjdk.org/jdk/compare/689cee3d0950e15e88a1f6738bfded00655dca9c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mpdonova The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (920c9aeb)
• 00: Full (0007259d)

[mpdonova]

Hello, I need someone to review this small PR. It just updates NSS to version 3.101 . Thanks!

[jaikiran]

Not an official review of the PR, since I don't have the necessary background of this library or the code. But this line has a typo in the copyright year - it should have been 2024.

[mpdonova]

Hello, I'm looking for a Reviewer for this small PR.

Thanks!

[mpdonova]

/integrate

[openjdk]

Going to push as commit c6f0a35.
Since your change was applied there have been 451 commits pushed to the master branch:

• f174bbd: 8337473: Remove sun/management/jdp tests from ProblemList on Linux-aarch64, MacOSX
• 8eb5684: 8337550: Add documentation to TestOutOfMemoryDuringInit.java
• cf1230a: 8337546: Remove unused GCCause::_adaptive_size_policy
• 65646b5: 8337457: Redundant Math.round call in AquaProgressBarUI#getStringPlacement
• 8af2ef3: 8331015: Obsolete -XX:+UseNotificationThread
• 97f7c03: 8336495: Remove unnecessary casts in output.cpp
• a45bb55: 8337501: JFR: Use TimespanUnit
• 8f039b5: 8336919: Cleanup and rename tags in placeholders code
• e4c7850: 8337027: Parallel: Obsolete BaseFootPrintEstimate
• fdb4350: 8324345: Stack overflow during C2 compilation when splitting memory phi
• ... and 441 more: https://git.openjdk.org/jdk/compare/689cee3d0950e15e88a1f6738bfded00655dca9c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mpdonova Pushed as commit c6f0a35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.