8334598: Default classlist in JDK is not deterministic after JDK-8293980

[iklam]

More filtering is needed when building the default archive in the JDK: constant pool resolution when running the build.tools.classlist.HelloClasslist program is not deterministic (due to concurrency in core library classes). This could cause different values in the @cp lines in the classlist file. The benefit of pre-resolved constant pool entries is more visible for custom archives and not so much for the default archive in the JDK, so we disable this optimization for the default CDS archive, until we can find a way to make it deterministic.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8334598: Default classlist in JDK is not deterministic after JDK-8293980 (Bug - P4)

Reviewers

• Calvin Cheung (@calvinccheung - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19868/head:pull/19868
$ git checkout pull/19868

Update a local copy of the PR:
$ git checkout pull/19868
$ git pull https://git.openjdk.org/jdk.git pull/19868/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19868

View PR using the GUI difftool:
$ git pr show -t 19868

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19868.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334598: Default classlist in JDK is not deterministic after JDK-8293980

Reviewed-by: ccheung, dholmes, stuefe, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• c30e040: 8331911: Reconsider locking for recently disarmed nmethods
• 974dca8: 8334223: Make Arena MEMFLAGs immutable
• e527e1c: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal
• 3a26bbc: 8185429: [macos] After a modal dialog is closed, no window becomes active

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (44f60e8c)

[calvinccheung]

LGTM

[dholmes-ora]

Seems reasonable. Thanks.

[tstuefe]

+1

[iklam]

Thanks @calvinccheung @dholmes-ora @tstuefe @erikj79 for the review.
/integrate

[openjdk]

Going to push as commit 7429c37.
Since your change was applied there have been 10 commits pushed to the master branch:

• 9c89f08: 8334421: assert(!oldbox->is_unbalanced()) failed: this should not be called for unbalanced region
• 57f8b91: 8333658: NMT: Use an allocator with 4-byte pointers to save memory in NativeCallStackStorage
• 6c67933: 8334899: Test runtime/cds/appcds/javaldr/ExceptionDuringDumpAtObjectsInitPhase.java failed after JDK-8306580
• cae94b2: 8334397: RISC-V: verify perf of ReverseBytesS/US
• 75a2afa: 8248981: Specify list of standard message digest and mgf algorithms for RSASSA-PSS signature
• baafa66: 8334287: Man page update for jstatd deprecation
• c30e040: 8331911: Reconsider locking for recently disarmed nmethods
• 974dca8: 8334223: Make Arena MEMFLAGs immutable
• e527e1c: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal
• 3a26bbc: 8185429: [macos] After a modal dialog is closed, no window becomes active

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit 7429c37.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.