Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved #19877

Closed

Conversation

stefank
Copy link
Member

@stefank stefank commented Jun 25, 2024

Hi all,

This pull request contains a backport of commit 31e8deba from the openjdk/jdk repository.

The commit being backported was authored by Liming Liu on 17 Jun 2024 and was reviewed by Stefan Karlsson, Johan Sjölen and Thomas Stuefe.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved (Bug - P2)
  • JDK-8325218: gc/parallel/TestAlwaysPreTouchBehavior.java fails (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19877/head:pull/19877
$ git checkout pull/19877

Update a local copy of the PR:
$ git checkout pull/19877
$ git pull https://git.openjdk.org/jdk.git pull/19877/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19877

View PR using the GUI difftool:
$ git pr show -t 19877

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19877.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 25, 2024

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved
8325218: gc/parallel/TestAlwaysPreTouchBehavior.java fails

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the jdk23 branch:

  • b5fbdb2: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538
  • 2086b0f: 8334629: [BACKOUT] PhaseIdealLoop::conditional_move is too conservative
  • d151050: 8334594: Generational ZGC: Deadlock after OopMap rewrites in 8331572
  • ae49182: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal
  • 37ebece: 8332717: ZGC: Division by zero in heuristics

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk23 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 31e8debae63e008da79e403bcb870a7be631af2c 8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved Jun 25, 2024
@openjdk
Copy link

openjdk bot commented Jun 25, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 25, 2024
@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@stefank The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jun 25, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 25, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 27, 2024
@stefank
Copy link
Member Author

stefank commented Jun 27, 2024

Thanks Thomas! Tier1 passes.
/integrate

@openjdk
Copy link

openjdk bot commented Jun 27, 2024

Going to push as commit d7b9454.
Since your change was applied there have been 5 commits pushed to the jdk23 branch:

  • b5fbdb2: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538
  • 2086b0f: 8334629: [BACKOUT] PhaseIdealLoop::conditional_move is too conservative
  • d151050: 8334594: Generational ZGC: Deadlock after OopMap rewrites in 8331572
  • ae49182: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal
  • 37ebece: 8332717: ZGC: Division by zero in heuristics

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2024
@openjdk openjdk bot closed this Jun 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2024
@openjdk
Copy link

openjdk bot commented Jun 27, 2024

@stefank Pushed as commit d7b9454.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants