Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64 #19881

Closed
wants to merge 1 commit into from

Conversation

dfuch
Copy link
Member

@dfuch dfuch commented Jun 25, 2024

Please find here a change that makes the test IPMulticastIF.java more resilient to platform-dependent behavior.

The test assumed that you could set any outbound network interface on a bound datagram channel. This is in fact system dependent and could fail if the outbound interface and the local IP Address of the bound socket do not match.

The test is modified to only select the interfaces to which the local address is bound. It also verifies that any interface can be set if the socket is bound to the wildcard (any local address).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19881/head:pull/19881
$ git checkout pull/19881

Update a local copy of the PR:
$ git checkout pull/19881
$ git pull https://git.openjdk.org/jdk.git pull/19881/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19881

View PR using the GUI difftool:
$ git pr show -t 19881

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19881.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 25, 2024

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • b88af94: 8269870: PS: Membar in PSPromotionManager::copy_unmarked_to_survivor_space could be relaxed
  • a5f401f: 8334650: Add debug information about whether an Assertion Predicate is for the init or last value
  • 25c3845: 8333133: Simplify QuickSort::sort
  • c66f785: 8334505: RISC-V: Several tests fail when MaxVectorSize does not match VM_Version::_initial_vector_length
  • f101e15: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538
  • b3bf31a: 8333542: Breakpoint in parallel code does not work
  • 86b0cf2: 8334653: ISO 4217 Amendment 177 Update
  • 861aefc: 8334418: Update IANA Language Subtag Registry to Version 2024-06-14
  • f8bf470: 8334810: Redo: Un-ProblemList LocaleProvidersRun and CalendarDataRegression
  • 933eaba: 8334629: [BACKOUT] PhaseIdealLoop::conditional_move is too conservative
  • ... and 13 more: https://git.openjdk.org/jdk/compare/55c796946158aab1d019a57b77a33441d7b13065...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8334600 8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64 Jun 25, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 25, 2024
@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@dfuch The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Jun 25, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 25, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 26, 2024
@dfuch
Copy link
Member Author

dfuch commented Jun 26, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 26, 2024

Going to push as commit f23295e.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 741a0f3: 8334241: Adjust API docs side bar dimensions
  • 4ce8822: 8334037: Local class creation in lambda in pre-construction context crashes javac
  • 7f6804c: 8334872: BigEndian: java/lang/invoke/condy Tests failing since JDK-8294960
  • e139005: 8333994: NMT: call stacks should show source information
  • b88af94: 8269870: PS: Membar in PSPromotionManager::copy_unmarked_to_survivor_space could be relaxed
  • a5f401f: 8334650: Add debug information about whether an Assertion Predicate is for the init or last value
  • 25c3845: 8333133: Simplify QuickSort::sort
  • c66f785: 8334505: RISC-V: Several tests fail when MaxVectorSize does not match VM_Version::_initial_vector_length
  • f101e15: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538
  • b3bf31a: 8333542: Breakpoint in parallel code does not work
  • ... and 17 more: https://git.openjdk.org/jdk/compare/55c796946158aab1d019a57b77a33441d7b13065...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 26, 2024
@openjdk openjdk bot closed this Jun 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 26, 2024
@openjdk
Copy link

openjdk bot commented Jun 26, 2024

@dfuch Pushed as commit f23295e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member

@dfuch Do you mind I will try to backport this patch to jdk21 and jdk17.

@dfuch
Copy link
Member Author

dfuch commented Jun 28, 2024

@sendaoYan that would be a question for the maintainers of jdk21 and jdk17 to answer.
See https://openjdk.org/projects/jdk-updates/approval.html

@sendaoYan
Copy link
Member

@sendaoYan that would be a question for the maintainers of jdk21 and jdk17 to answer. See https://openjdk.org/projects/jdk-updates/approval.html

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants