-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64 #19881
Conversation
👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into |
@dfuch This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit f23295e.
Your commit was automatically rebased without conflicts. |
@dfuch Do you mind I will try to backport this patch to jdk21 and jdk17. |
@sendaoYan that would be a question for the maintainers of jdk21 and jdk17 to answer. |
Thanks. |
Please find here a change that makes the test IPMulticastIF.java more resilient to platform-dependent behavior.
The test assumed that you could set any outbound network interface on a bound datagram channel. This is in fact system dependent and could fail if the outbound interface and the local IP Address of the bound socket do not match.
The test is modified to only select the interfaces to which the local address is bound. It also verifies that any interface can be set if the socket is bound to the wildcard (any local address).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19881/head:pull/19881
$ git checkout pull/19881
Update a local copy of the PR:
$ git checkout pull/19881
$ git pull https://git.openjdk.org/jdk.git pull/19881/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19881
View PR using the GUI difftool:
$ git pr show -t 19881
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19881.diff
Webrev
Link to Webrev Comment