8333308: javap --system handling doesn't work on internal class names

[SoniaZaldana]

Hi all,

This PR addresses JDK-8333308 enabling javap -system to handle internal class names.

Thanks,
Sonia

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8333308: javap --system handling doesn't work on internal class names

Issue

• JDK-8333308: javap --system handling doesn't work on internal class names (Bug - P4)

Reviewers

• Chen Liang (@liach - Committer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19883/head:pull/19883
$ git checkout pull/19883

Update a local copy of the PR:
$ git checkout pull/19883
$ git pull https://git.openjdk.org/jdk.git pull/19883/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19883

View PR using the GUI difftool:
$ git pr show -t 19883

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19883.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333308: javap --system handling doesn't work on internal class names

Reviewed-by: liach, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 153 new commits pushed to the master branch:

• 50dd962: 8335007: Inline OopMapCache table
• 79a2301: 8322859: Parallel: Move transform_stack_chunk
• 37e7698: 8335154: jcmd VM.classes -verbose=false does not set verbose to false
• f3b69da: 8335136: Underscore as parameter name in one-parameter functional types fails to compile
• 46b817b: 8333363: ubsan: instanceKlass.cpp: runtime error: member call on null pointer of type 'struct AnnotationArray'
• 0fc5b27: 8332014: since-checker - Fix @ since tags in jdk.jshell
• 9d20b58: 8334328: Reduce object allocation for FloatToDecimal and DoubleToDecimal
• 9bb675f: 8334719: (se) Deferred close of SelectableChannel may result in a Selector doing the final close before concurrent I/O on channel has completed
• 6682305: 8334779: Test compiler/c1/CanonicalizeArrayLength.java is timing out
• 3796fdf: 8328536: javac - crash on unknown type referenced in yield statement
• ... and 143 more: https://git.openjdk.org/jdk/compare/b09a45163ccc566b4f7653c2e9030e359396c90f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@liach, @tstuefe) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@SoniaZaldana The following labels will be automatically applied to this pull request:

• compiler
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (16a08461)

[liach]

Technically javap accepts both notations of a.b.C and a/b/C.class and accepts both . and $ as inner class separators. So this is fine. However it's hard to verify that the jdk in --system is really used, so I put a noreg-hard label on the original JBS issue; it's hard to create a suitable argument for the --system flag as you need a whole JDK.

[tstuefe]

Technically javap accepts both notations of a.b.C and a/b/C.class and accepts both . and $ as inner class separators. So this is fine. However it's hard to verify that the jdk in --system is really used, so I put a noreg-hard label on the original JBS issue; it's hard to create a suitable argument for the --system flag as you need a whole JDK.

Question, what is the noreg-hard label used for?

[AlanBateman]

Question, what is the noreg-hard label used for?

It's the label to mean that it's too hard or impossible write a regression test. It is documented in the JBS label dictionary but may not be widely known.

[tstuefe]

Question, what is the noreg-hard label used for?

It's the label to mean that it's too hard or impossible write a regression test. It is documented in the JBS label dictionary but may not be widely known.

Ah, thank you, and I never knew this documentation either.

[lahodaj]

For a test, I agree it is quite difficult. For the --system parameter, it would probably be possible to create a directory (e.g. $DIR), and inside it $DIR/lib, and copy suitable jrt-fs.jar and modules to it from $JDK/lib. And the use --system $DIR. But, it would still be fairly difficult to be sure the class' content is read from $DIR, not from the runtime JDK - modules would presumably need to be modified/different than the one for the runtime JDK, and that is not very easy.

[SoniaZaldana]

Hi everyone, thanks for taking a look.

Seeing the challenges involved with creating a jtreg test, what would you recommend as a viable way forward with this patch?

[liach]

noreg means no regression test. Since we cannot really create a shadow system modules to place alternative class files to render in javap, we probably just don't use a regression test.

[tstuefe]

+1

[SoniaZaldana]

/integrate

[openjdk]

@SoniaZaldana
Your change (at version 16a0846) is now ready to be sponsored by a Committer.

[tstuefe]

/sponsor

[openjdk]

Going to push as commit d5375c7.
Since your change was applied there have been 154 commits pushed to the master branch:

• 6b961ac: 8333786: Serial: Remove SerialHeap::_incremental_collection_failed
• 50dd962: 8335007: Inline OopMapCache table
• 79a2301: 8322859: Parallel: Move transform_stack_chunk
• 37e7698: 8335154: jcmd VM.classes -verbose=false does not set verbose to false
• f3b69da: 8335136: Underscore as parameter name in one-parameter functional types fails to compile
• 46b817b: 8333363: ubsan: instanceKlass.cpp: runtime error: member call on null pointer of type 'struct AnnotationArray'
• 0fc5b27: 8332014: since-checker - Fix @ since tags in jdk.jshell
• 9d20b58: 8334328: Reduce object allocation for FloatToDecimal and DoubleToDecimal
• 9bb675f: 8334719: (se) Deferred close of SelectableChannel may result in a Selector doing the final close before concurrent I/O on channel has completed
• 6682305: 8334779: Test compiler/c1/CanonicalizeArrayLength.java is timing out
• ... and 144 more: https://git.openjdk.org/jdk/compare/b09a45163ccc566b4f7653c2e9030e359396c90f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe @SoniaZaldana Pushed as commit d5375c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.