-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8335108: Build error after JDK-8333658 due to class templates #19890
Conversation
👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into |
@SoniaZaldana This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 22 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheShermanTanker, @jdksjolen) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@SoniaZaldana To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label hotspot |
@SoniaZaldana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this annoying g++ issue again. I honestly don't like that we have to adhere to C++20 without any of its benefits while being on C++14, but I think Kim has mentioned that this is a desirable warning to have, so approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still in draft, but LGTM.
/integrate |
@SoniaZaldana |
/sponsor |
Going to push as commit b5d5896.
Your commit was automatically rebased without conflicts. |
@TheShermanTanker @SoniaZaldana Pushed as commit b5d5896. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Coming late to the party, since y'all forgot the 24 hour rule for integrating Change looks good, and indeed I'd have agreed with a suggestion that it's |
I guess you learn something new every day, since this is the first time I'm hearing about the 24 hour rule (I always thought the only HotSpot requirement was 2 Reviewers, besides needing a 2 week waiting periods for Style Guide changes, never knew you had to wait 24 hours for regular ones too). It's a good thing this change was trivial in the end |
It's a JDK rule, not specific to HotSpot. I don't remember where that requirement originally came from, before being incorporated into the guide. I thought |
Its a rule that makes a lot of sense. Especially nowadays, post the xz-fiasco. |
I will claim the 24 hour rule is a generalization of "don't integrate before David in Australia has a chance to take a look" :D |
@kimbarrett Understood, thanks for bringing that to my attention. Luckily the change was trivial this time but I will note that for the future. |
I will now call it the David-Rule. |
The 24-hour rule is mentioned here: https://openjdk.org/guide/#life-of-a-pr
In general all PRs should be open for at least 24 hours to allow for reviewers in all time zones to get a chance to see it. It may actually happen that even 24 hours isn’t enough. Take into account weekends, holidays, and vacation times throughout the world and you’ll realize that a change that requires more than just a trivial review may have to be open for a while. In some areas [trivial] changes are allowed to be pushed without the 24 hour delay. Ask your reviewers if you think this applies to your change. |
Hi all,
This PR addresses 8335108.
The error arises as template-id is not allowed for constructor/destructor in C++20.
Testing:
Thanks,
Sonia
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19890/head:pull/19890
$ git checkout pull/19890
Update a local copy of the PR:
$ git checkout pull/19890
$ git pull https://git.openjdk.org/jdk.git pull/19890/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19890
View PR using the GUI difftool:
$ git pr show -t 19890
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19890.diff
Webrev
Link to Webrev Comment