8334886: jdk/jfr/api/recording/time/TestTimeMultiple.java failed with RuntimeException: getStopTime() > afterStop

[egahlin]

Could I have a review of a PR that fixes an intermittent failure. I have not been able to reproduce the failure after running the test 10 000 times, but it does reproduce quite easily without the fix.

It could be that the method awaitUniqueTimestamp() could also be removed with the introduction of a similar method in #19799 (which happens before the chunk rotation), but I rather fix it separately.

I want this change to be suitable for a backport to JDK 23 without additional regressions.

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8334886: jdk/jfr/api/recording/time/TestTimeMultiple.java failed with RuntimeException: getStopTime() > afterStop (Bug - P3)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19892/head:pull/19892
$ git checkout pull/19892

Update a local copy of the PR:
$ git checkout pull/19892
$ git pull https://git.openjdk.org/jdk.git pull/19892/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19892

View PR using the GUI difftool:
$ git pr show -t 19892

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19892.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334886: jdk/jfr/api/recording/time/TestTimeMultiple.java failed with RuntimeException: getStopTime() > afterStop

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• b6ffb44: 8335135: HttpURLConnection#HttpInputStream does not throw IOException when response is truncated
• 4ab7e98: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11
• 5909d54: 8326820: Metadata artificially kept alive
• d5375c7: 8333308: javap --system handling doesn't work on internal class names
• 6b961ac: 8333786: Serial: Remove SerialHeap::_incremental_collection_failed
• 50dd962: 8335007: Inline OopMapCache table
• 79a2301: 8322859: Parallel: Move transform_stack_chunk
• 37e7698: 8335154: jcmd VM.classes -verbose=false does not set verbose to false
• f3b69da: 8335136: Underscore as parameter name in one-parameter functional types fails to compile
• 46b817b: 8333363: ubsan: instanceKlass.cpp: runtime error: member call on null pointer of type 'struct AnnotationArray'
• ... and 26 more: https://git.openjdk.org/jdk/compare/b3bf31a0a08da679ec2fd21613243fb17b1135a9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e8cf0499)

[egahlin]

/integrate

[openjdk]

Going to push as commit 0e6b0cb.
Since your change was applied there have been 36 commits pushed to the master branch:

• b6ffb44: 8335135: HttpURLConnection#HttpInputStream does not throw IOException when response is truncated
• 4ab7e98: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11
• 5909d54: 8326820: Metadata artificially kept alive
• d5375c7: 8333308: javap --system handling doesn't work on internal class names
• 6b961ac: 8333786: Serial: Remove SerialHeap::_incremental_collection_failed
• 50dd962: 8335007: Inline OopMapCache table
• 79a2301: 8322859: Parallel: Move transform_stack_chunk
• 37e7698: 8335154: jcmd VM.classes -verbose=false does not set verbose to false
• f3b69da: 8335136: Underscore as parameter name in one-parameter functional types fails to compile
• 46b817b: 8333363: ubsan: instanceKlass.cpp: runtime error: member call on null pointer of type 'struct AnnotationArray'
• ... and 26 more: https://git.openjdk.org/jdk/compare/b3bf31a0a08da679ec2fd21613243fb17b1135a9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 0e6b0cb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[egahlin]

/backport openjdk/jdk:jdk23

[openjdk]

@egahlin the backport was successfully created on the branch backport-egahlin-0e6b0cba-jdk23 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk23, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 0e6b0cba from the openjdk/jdk repository.

The commit being backported was authored by Erik Gahlin on 27 Jun 2024 and was reviewed by Markus Grönlund.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-egahlin-0e6b0cba-jdk23:backport-egahlin-0e6b0cba-jdk23
$ git checkout backport-egahlin-0e6b0cba-jdk23
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-egahlin-0e6b0cba-jdk23