8333583: Crypto-XDH.generateSecret regression after JDK-8329538

[vpaprotsk]

Hi all,

This pull request contains a backport of commit f101e153 from the openjdk/jdk repository.

The commit being backported was authored by Volodymyr Paprotski on 25 Jun 2024 and was reviewed by Sandhya Viswanathan, Vladimir Kozlov, Ferenc Rakoczi and Anthony Scarpino.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8333583: Crypto-XDH.generateSecret regression after JDK-8329538 (Bug - P3)

Reviewers

• @AkshDesai04 (no known openjdk.org user name / role)
• Tobias Hartmann (@TobiHartmann - Reviewer)
• Sandhya Viswanathan (@sviswa7 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19893/head:pull/19893
$ git checkout pull/19893

Update a local copy of the PR:
$ git checkout pull/19893
$ git pull https://git.openjdk.org/jdk.git pull/19893/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19893

View PR using the GUI difftool:
$ git pr show -t 19893

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19893.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vpaprotsk! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vpaprotsk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333583: Crypto-XDH.generateSecret regression after JDK-8329538

Reviewed-by: thartmann, sviswanathan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the jdk23 branch:

• 2086b0f: 8334629: [BACKOUT] PhaseIdealLoop::conditional_move is too conservative
• d151050: 8334594: Generational ZGC: Deadlock after OopMap rewrites in 8331572
• ae49182: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk23 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @sviswa7) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@vpaprotsk The following labels will be automatically applied to this pull request:

• build
• hotspot
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3c5cd998)

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[TobiHartmann]

Looks good to me.

[vpaprotsk]

/integrate

[openjdk]

@vpaprotsk
Your change (at version 3c5cd99) is now ready to be sponsored by a Committer.

[sviswa7]

/sponsor

[openjdk]

Going to push as commit b5fbdb2.
Since your change was applied there have been 3 commits pushed to the jdk23 branch:

• 2086b0f: 8334629: [BACKOUT] PhaseIdealLoop::conditional_move is too conservative
• d151050: 8334594: Generational ZGC: Deadlock after OopMap rewrites in 8331572
• ae49182: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal

Your commit was automatically rebased without conflicts.

[openjdk]

@sviswa7 @vpaprotsk Pushed as commit b5fbdb2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.